| Subject: | $VERSION is not warnings-safe and not working properly (patch included) |
Hi,
the module version does not appear to be safe from warnings and is not
working properly:
Show quoted text
> perl -e 'use warnings; use Digest::Whirlpool 1.0'
Argument "1.0.6" isn't numeric in subroutine entry at -e line 1.
This is due to your three dots versioning, as version comparison uses
numerical comparison. This forbids people to correctly force a given
version in their programs (for instance, one might try to force version
1.0.4 or greater to ensure "->add('foo')->digest" sintax will work as
expected by doing "use Digest::Whirlpool 1.0.4").
The easy way to fix this while keeping three dot versioning is to change
line 7 of Whirlpool.pm from:
our $VERSION = '1.0.6';
to:
use version; our $VERSION = qv('1.0.6');
I really enjoy Digest::Whirlpool, thanks for all your work in it!