Bug #40478 for libnet: Add starttls to Net::Cmd

Tue Oct 28 21:09:19 2008 dwheeler [...] cpan.org - Ticket created

CC:	rjbs [...] cpan.org
Subject:	Add starttls to Net::Cmd
Date:	Tue, 28 Oct 2008 18:08:49 -0700
To:	bug-libnet [...] rt.cpan.org
From:	"David E. Wheeler" <dwheeler [...] cpan.org>

Hi Graham, I'm surprised not to see anything like this in the libnet queue! I recently got a patch for SVN::Notify adding TLS support by using Net::SMTP::TLS. Since someone might also want to do auth, though, this is suboptimal. Ideally, Net::SMTP would just have a `starttls` parameter. Is this do-able? Perhaps it could be in Net::Cmd so that all of the libnet modules could use it. I'm sure it's not easy to do, and you probably don't have the tuits for it, but maybe someone out there reading this does? Maybe something could be borrowed from Net::SMTP::TLS. Thanks for listening! David

Tue Oct 28 22:43:48 2008 gbarr [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #40478] Add starttls to Net::Cmd
Date:	Tue, 28 Oct 2008 21:43:19 -0500
To:	bug-libnet [...] rt.cpan.org
From:	Graham Barr <gbarr [...] pobox.com>

Anything is do-able. Unfortunately when Net::Cmd was written, just about a decade ago now, a design decision was made to inherit from the socket object instead of containing it as an attribute. This creates a problem for IO::Socket::SSL/starttls which mutates the socket object. I could change it to not inherit, but I know there are people out there that use Net::Cmd and treat the object as the socket. Net::SMTP::TLS re-implemented Net::SMTP from scratch :-( Graham.

Tue Oct 28 22:43:50 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 06 12:05:00 2009 dwheeler [...] cpan.org - Dependency by ticket #40188 added

Mon Apr 06 12:08:27 2009 dwheeler [...] cpan.org - Correspondence added

On Tue Oct 28 22:43:48 2008, gbarr@pobox.com wrote: Show quoted text

> I could change it to not inherit, but I know there are people out > there that use Net::Cmd and treat the object as the socket.

Couldn't there be some sort of delegation so that the object could behave like a socket where appropriate? Or is it treated like a file handle when it's used a socket, and so it could just be a tie interface that handles that stuff? I'm not familiar with the code, just taking a stab here. Show quoted text

> Net::SMTP::TLS re-implemented Net::SMTP from scratch :-(

Yeah. Ugh. Thanks, David

Mon Apr 06 12:17:37 2009 gbarr [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #40478] Add starttls to Net::Cmd
Date:	Mon, 6 Apr 2009 11:12:53 -0500
To:	bug-libnet [...] rt.cpan.org
From:	Graham Barr <gbarr [...] pobox.com>

On Apr 6, 2009, at 11:08 AM, David Wheeler via RT wrote: Show quoted text

> Queue: libnet > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=40478 > > > On Tue Oct 28 22:43:48 2008, gbarr@pobox.com wrote: >

>> I could change it to not inherit, but I know there are people out >> there that use Net::Cmd and treat the object as the socket.

> > Couldn't there be some sort of delegation so that the object could > behave like a socket where appropriate? Or is it treated like a file > handle when it's used a socket, and so it could just be a tie > interface > that handles that stuff? I'm not familiar with the code, just taking a > stab here.

Yes. I think the best solution for Net::Cmd to to store the socket as an attribute and add a tie interface for backwards compatibility, but change all modules in libnet not to assume it is a socket. Patches welcome. There is a git repository at http://git.goingon.net/?p=libnet.git;a=summary I will probably place it on github sometime. Show quoted text

>> Net::SMTP::TLS re-implemented Net::SMTP from scratch :-(

> > Yeah. Ugh.

I agree. Graham.

Mon Apr 06 12:22:37 2009 dwheeler [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #40478] Add starttls to Net::Cmd
Date:	Mon, 6 Apr 2009 09:22:03 -0700
To:	bug-libnet [...] rt.cpan.org
From:	"David E. Wheeler" <dwheeler [...] cpan.org>

On Apr 6, 2009, at 9:17 AM, Graham Barr via RT wrote: Show quoted text

> I think the best solution for Net::Cmd to to store the socket as an > attribute > and add a tie interface for backwards compatibility, but change all > modules > in libnet not to assume it is a socket. > > Patches welcome. There is a git repository at http://git.goingon.net/?p=libnet.git;a=summary > > I will probably place it on github sometime.

Heh, yeah, I haven't got the tuits either. Maybe someone who wants TLS for SVN::Notify will have them. :-) Best, David

Tue Aug 13 09:53:42 2013 dwheeler [...] cpan.org - Dependency by ticket #40188 deleted

Tue Aug 13 09:53:43 2013 dwheeler [...] cpan.org - Reference by ticket #40188 added

Wed Nov 19 08:22:50 2014 shay [...] cpan.org - Correspondence added

SSL support was added to Net::(FTP|NNTP|POP3|SMTP) in libnet-1.28. Do you think that resolves this ticket, or is there still more that needs to be done?

Wed Nov 26 20:48:23 2014 dwheeler [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #40478] Add starttls to Net::Cmd
Date:	Wed, 26 Nov 2014 17:48:11 -0800
To:	bug-libnet [...] rt.cpan.org
From:	"David E. Wheeler" <dwheeler [...] cpan.org>

On Nov 19, 2014, at 5:22 AM, Steve Hay via RT <bug-libnet@rt.cpan.org> wrote: Show quoted text

> Do you think that resolves this ticket, or is there still more that needs to be done?

I dunno. I switched to Net::SMTP::TLS years ago to get around this limitation. https://github.com/theory/svn-notify/commit/cb9237914235d3bef4f88e61324204179ef8b7eb Best, David

Thu Nov 27 03:50:53 2014 shay [...] cpan.org - Correspondence added

On Wed Nov 26 20:48:23 2014, DWHEELER wrote: Show quoted text

> On Nov 19, 2014, at 5:22 AM, Steve Hay via RT <bug-libnet@rt.cpan.org> > wrote: >

> > Do you think that resolves this ticket, or is there still more that > > needs to be done?

> > I dunno. I switched to Net::SMTP::TLS years ago to get around this > limitation. > > https://github.com/theory/svn- > notify/commit/cb9237914235d3bef4f88e61324204179ef8b7eb >

Ok, thanks. I will assume that this ticket is resolved then. If you ever consider returning to Net::SMTP and find that it still doesn't meet your needs then please re-open this ticket or create a new one.

Thu Nov 27 03:50:55 2014 shay [...] cpan.org - Status changed from 'open' to 'resolved'