Bug #40473 for RT-Authen-ExternalAuth: Small bug in ExternalAuth

Tue Oct 28 17:37:35 2008 nicholas_kartsioukas [...] cuesta.edu - Ticket created

CC:	zordrak [...] cpan.org
Subject:	Small bug in ExternalAuth
Date:	Tue, 28 Oct 2008 14:37:07 -0700
To:	bug-RT-Authen-ExternalAuth [...] rt.cpan.org
From:	Nick Kartsioukas <nicholas_kartsioukas [...] cuesta.edu>

I found a bug in ExternalAuth that's only triggered when doing debug-level logging. This error is received when logging in with a valid username but an incorrect password: Can't call method "as_string" on an undefined value at /home/rtemail/rt3.6/local/lib/RT/User_Vendor.pm line 890. Afterwards, if I reload the RT URL, it allows me access as that user. Lines 885-892: $RT::Logger->debug( "LDAP Search === ", "Base:", $base, "== Filter:", $disable_filter->as_string, "== Attrs:", join(',',@attrs)); If I change line 890 to: $disable_filter, then everything works properly (no errors, rejects me with an incorrect password, allows me in with a correct password). Let me know if this isn't a bug and I'm actually doing something terrible that would cause this to happen instead :)

Tue Oct 28 19:19:37 2008 cpan [...] jibsheet.com - Correspondence added

On Tue Oct 28 17:37:35 2008, nicholas_kartsioukas@cuesta.edu wrote: Show quoted text

> I found a bug in ExternalAuth that's only triggered when doing > debug-level logging.

Did you define a d_filter in your config? Show quoted text

> > This error is received when logging in with a valid username but an > incorrect password: > Can't call method "as_string" on an undefined value at > /home/rtemail/rt3.6/local/lib/RT/User_Vendor.pm line 890. > > Afterwards, if I reload the RT URL, it allows me access as that user. > > Lines 885-892: > $RT::Logger->debug( "LDAP Search === ", > "Base:", > $base, > "== Filter:", > $disable_filter->as_string, > "== Attrs:", > join(',',@attrs)); > > If I change line 890 to: > $disable_filter, > then everything works properly (no errors, rejects me with an incorrect > password, allows me in with a correct password). > > Let me know if this isn't a bug and I'm actually doing something > terrible that would cause this to happen instead :)

Tue Oct 28 19:19:39 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 28 19:40:45 2008 nicholas_kartsioukas [...] cuesta.edu - Correspondence added

Subject:	Re: [rt.cpan.org #40473] Small bug in ExternalAuth
Date:	Tue, 28 Oct 2008 16:40:08 -0700
To:	bug-RT-Authen-ExternalAuth [...] rt.cpan.org
From:	Nick Kartsioukas <nicholas_kartsioukas [...] cuesta.edu>

Kevin Falcone via RT wrote: Show quoted text

> Did you define a d_filter in your config?

Yes, it is defined as the string 'none'.

Tue Oct 28 20:49:50 2008 cpan [...] jibsheet.com - Correspondence added

On Tue Oct 28 19:40:45 2008, nicholas_kartsioukas@cuesta.edu wrote: Show quoted text

> Kevin Falcone via RT wrote:

> > Did you define a d_filter in your config?

> > Yes, it is defined as the string 'none'.

I don't believe that is valid ldap filter syntax. RT-Authen-ExternalAuth should do a better job error checking so it can yell about it. There is now a branch for that. -kevin

Wed Oct 29 06:05:41 2008 zordrak [...] cpan.org - Correspondence added

On Tue Oct 28 20:49:50 2008, FALCONE wrote: Show quoted text

> On Tue Oct 28 19:40:45 2008, nicholas_kartsioukas@cuesta.edu wrote:

> > Kevin Falcone via RT wrote:

> > > Did you define a d_filter in your config?

> > > > Yes, it is defined as the string 'none'.

> > I don't believe that is valid ldap filter syntax.

Confirmed. All LDAP filters need to be specified with valid ldap syntax: d_filter => '(objectClass=Martian)', Show quoted text

> > RT-Authen-ExternalAuth should do a better job > error checking so it can yell about it. There is > now a branch for that.

Trying to keep up with you, but failing :)

Wed Oct 29 11:21:51 2008 nicholas_kartsioukas [...] cuesta.edu - Correspondence added

Subject:	Re: [rt.cpan.org #40473] Small bug in ExternalAuth
Date:	Wed, 29 Oct 2008 08:21:09 -0700
To:	bug-RT-Authen-ExternalAuth [...] rt.cpan.org
From:	Nick Kartsioukas <nicholas_kartsioukas [...] cuesta.edu>

Mike Peachey via RT wrote: Show quoted text

> Confirmed. All LDAP filters need to be specified with valid ldap syntax: > d_filter => '(objectClass=Martian)',

Ah, I understand now. It wasn't documented in the example config as to the format, I assumed it was just doing a string match.

Sat Nov 01 14:45:05 2008 zordrak [...] cpan.org - Status changed from 'open' to 'resolved'