Skip Menu |

This queue is for tickets about the Text-Iconv CPAN distribution.

Report information
The Basics
Id: 40431
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Text-Iconv

People
Owner: mxp [...] dynalabs.de
Requestors: CHORNY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.7
Fixed in: (no value)



Subject: better Makefile.PL
Behaves better when reporting for cpantesters. More fields in META.yml (use latest EU::MM). -- Alexandr Ciornii, http://chorny.net
Subject: Makefile.PL.patch
--- Makefile.PL.dist 2007-10-17 18:06:22.000000000 +0300 +++ Makefile.PL 2008-10-27 19:59:33.875000000 +0200 @@ -75,7 +75,7 @@ print "Failed to find iconv, please check your settings and re-run as:\n"; print "$^X Makefile.PL LIBS='-L/path/to/lib' INC='-I/path/to/include'\n"; - exit 1; + exit 0; #cpantesters standard } ############################################################################### @@ -85,13 +85,14 @@ 'NAME' => 'Text::Iconv', 'VERSION_FROM' => 'Iconv.pm', # finds $VERSION 'PREREQ_PM' => {}, # e.g., Module::Name => 1.1 - ($] >= 5.005 ? ## Add these new keywords supported since 5.005 - (ABSTRACT_FROM => 'Iconv.pm', # retrieve abstract from module - AUTHOR => 'Michael Piotrowski <mxp@dynalabs.de>') : ()), + ABSTRACT_FROM => 'Iconv.pm', # retrieve abstract from module + AUTHOR => 'Michael Piotrowski <mxp@dynalabs.de>', 'LIBS' => $config{LIBS}, 'DEFINE' => "@DEFINE", 'INC' => $config{INC}, 'dist' => {COMPRESS => 'gzip', SUFFIX => 'gz'}, + ($ExtUtils::MakeMaker::VERSION ge '6.48'? + ('LICENSE' => 'perl', 'MIN_PERL_VERSION' => 5.006,) : ()), ); ###############################################################################
I modified Makefile.PL to as suggested. I'm not sure whether I find it a good idea to return 0 on errors, because you then can't say something like $ perl Makefile.PL && make but well... The changes will be in the next release (no date scheduled yet).