Skip Menu |

This queue is for tickets about the Archive-Tar CPAN distribution.

Report information
The Basics
Id: 40426
Status: resolved
Priority: 0/
Queue: Archive-Tar
People
Owner: Nobody in particular
Requestors: toddr [...] cpanel.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Oct 27 13:31:00 2008 toddr [...] cpanel.net - Ticket created
Subject: Archive Tar to support direct Archive::Tar::File adds
Hi, with this minor patch below, one could create tar files completeley in memory: diff --git a/Tar.pm b/Tar.pm index 839e113..2cd8cac 100644 --- a/Tar.pm +++ b/Tar.pm @@ -1308,6 +1308,10 @@ sub add_files { my @rv; for my $file ( @files ) { + if(ref($file) eq 'Archive::Tar::File') { + push @rv, $file; # Archive::Tar::File Object was passed directly. + next; + } unless( -e $file || -l $file ) { $self->_error( qq[No such file: '$file'] ); next;
  Mon Oct 27 16:22:23 2008 toddr [...] cpanel.net - Correspondence added
From: todd.e.rinaldo [...] jpmorgan.com
I missed the subroutine add_data on first pass, but still, it might not be a bad idea to provide this interface...
  Thu Dec 04 13:31:40 2008 kane [...] cpan.org - Correspondence added
On Mon Oct 27 13:31:00 2008, todd_rinaldo wrote: Show quoted text
> Hi, with this minor patch below, one could create tar files completeley > in memory: > > diff --git a/Tar.pm b/Tar.pm > index 839e113..2cd8cac 100644 > --- a/Tar.pm > +++ b/Tar.pm > @@ -1308,6 +1308,10 @@ sub add_files { > > my @rv; > for my $file ( @files ) { > + if(ref($file) eq 'Archive::Tar::File') { > + push @rv, $file; # Archive::Tar::File Object was passed > directly. > + next; > + } > unless( -e $file || -l $file ) { > $self->_error( qq[No such file: '$file'] ); > next;
Not a bad interface addition. This has been added now. Thanks for the patch!
  Thu Dec 04 13:31:43 2008 The RT System itself - Status changed from 'new' to 'open'
  Thu Dec 04 13:31:43 2008 kane [...] cpan.org - Status changed from 'open' to 'resolved'