Skip Menu |

This queue is for tickets about the GD-Tab-Guitar CPAN distribution.

Report information
The Basics
Id: 40408
Status: resolved
Priority: 0/
Queue: GD-Tab-Guitar
People
Owner: Nobody in particular
Requestors: taro.nishino [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.02
Fixed in: 0.03

History Show all quoted text
  Mon Oct 27 07:58:10 2008 taro.nishino [...] gmail.com - Ticket created
Subject: missing "binmode"
Hi, Koichi, Long time no see. As you can see from my cpan-testers report #2493023, the test ended in failure under MSWin32. That is because you forget "binmode." taht is, you should do as follows: --- 01_methods.t.org Mon Oct 27 20:28:20 2008 +++ 01_methods.t Mon Oct 27 20:38:09 2008 @@ -21,6 +21,7 @@ sub fileread { my $fh = IO::File->new(shift, 'r'); + $fh->binmode(); return do {local $/ = undef; <$fh>}; } In fact, after applying that patch, the test is as follows: C:\temp\GD-Tab-Guitar-0.02>perl -Iblib t/01_methods.t 1..9 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 ok 9 Best regards, Taro Nishino
  Wed Oct 29 04:42:40 2008 TANIGUCHI [...] cpan.org - Fixed in 0.03 added
  Wed Oct 29 04:43:31 2008 TANIGUCHI [...] cpan.org - Status changed from 'new' to 'resolved'
  Wed Oct 29 04:47:02 2008 TANIGUCHI [...] cpan.org - Correspondence added
patch applied. thanks for sending your patch. On Mon Oct 27 07:58:10 2008, taro-nishino wrote: Show quoted text
> Hi, Koichi, > > Long time no see. > As you can see from my cpan-testers report #2493023, the test ended in > failure under > MSWin32. > That is because you forget "binmode." taht is, you should do as > follows: > > --- 01_methods.t.org Mon Oct 27 20:28:20 2008 > +++ 01_methods.t Mon Oct 27 20:38:09 2008 > @@ -21,6 +21,7 @@ > > sub fileread { > my $fh = IO::File->new(shift, 'r'); > + $fh->binmode(); > return do {local $/ = undef; <$fh>}; > } > > > In fact, after applying that patch, the test is as follows: > > C:\temp\GD-Tab-Guitar-0.02>perl -Iblib t/01_methods.t > 1..9 > ok 1 > ok 2 > ok 3 > ok 4 > ok 5 > ok 6 > ok 7 > ok 8 > ok 9 > > > Best regards, > Taro Nishino >
  Wed Oct 29 04:47:04 2008 The RT System itself - Status changed from 'resolved' to 'open'
  Wed Oct 29 04:47:53 2008 TANIGUCHI [...] cpan.org - Status changed from 'open' to 'resolved'