Subject: | Two small issues that popped up while using AWS::SDB |
The attached patch does not include tests, but there was no really
simple tests to expand on.
It fixes a few problems I had while implementing a KiokuDB backend for
SimpleDB, which in turn has some live tests that pass with the patch,
and not without it :)
These two bugs now sort of block release of the SimpleDB backend.
If you would like me to do more, or change the patch somehow, feel free
to get in touch :)
Subject: | small_fixes.diff |
diff -ur Amazon.orig/SimpleDB/Response.pm Amazon/SimpleDB/Response.pm
--- Amazon.orig/SimpleDB/Response.pm 2008-10-25 16:33:47.000000000 +0200
+++ Amazon/SimpleDB/Response.pm 2008-10-26 09:23:47.000000000 +0100
@@ -14,7 +14,12 @@
sub new {
my $class = shift;
- my $args = shift || {};
+ my $args = {};
+ if (ref($_[0]) eq 'HASH') {
+ $args = shift;
+ } else {
+ $args = +{ @_ };
+ }
croak "No account" unless $args->{account};
my $r = $args->{http_response};
croak 'No HTTP::Response object in http_response'
@@ -41,6 +46,7 @@
}
my $self = bless {}, $class;
$self->{'account'} = $args->{account};
+ $self->{'domain'} = $args->{domain} if $args->{domain};
$self->{'http_response'} = $r;
$self->{'http_status'} = $r->code;
$self->{'content'} = $tree;