| Date: | Mon, 6 Oct 2003 15:13:15 +0100 |
| From: | Richard Clamp <richardc [...] unixbeard.net> |
| To: | bug-CPANPLUS [...] rt.cpan.org |
| Subject: | Flag not cleared? Mislabelling things as failed. |
This is a script generated from CPANPLUS 0.045
http://unixbeard.net/~richardc/cpanp_err
In summary:
install A B C D
success A
FAIL B
success C
success D
reports:
success A
FAIL B
FAIL C!
FAIL D!
Since C and D didn't actually fail it's odd to be told they did.
By inspection I've tracked it to around line 286 of CPANPLUS::Backend:
$modobj->status->install(!$flag);
### set the return value ###
$href->{$mod} = $modobj->status->install;
}
}
That's looping over all modules to be installed, but within the loop
the $flag can only be set and is never cleared. Perhaps something as
simple as:
$modobj->status->install(!$flag);
+ $flag = 0;
### set the return value ###
$href->{$mod} = $modobj->status->install;
}
}
would remedy it but I'm not sure enough to make a real patch.
--
Richard Clamp <richardc@unixbeard.net>