Bug #40152 for WWW-Facebook-API: Test failures in 0.4.14

Sat Oct 18 12:29:52 2008 gregoa [...] debian.org - Ticket created

Subject:	Test failures in 0.4.14
Date:	Sat, 18 Oct 2008 18:29:28 +0200
To:	bug-WWW-Facebook-API [...] rt.cpan.org
From:	gregor herrmann <gregoa [...] debian.org>

Hi, two perlcritic tests fail for 0.4.14: t/perlcritic....... # Failed test 'Test::Perl::Critic for "blib/lib/WWW/Facebook/API/Feed.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 99. # # Perl::Critic found these violations in "blib/lib/WWW/Facebook/API/Feed.pm": # Found "\N{SPACE}" at the end of the line at line 29, column 15. Don't use whitespace at the end of lines. (Severity: 1) # Failed test 'Test::Perl::Critic for "blib/lib/WWW/Facebook/API/SMS.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 99. # # Perl::Critic found these violations in "blib/lib/WWW/Facebook/API/SMS.pm": # Subroutine name is a homonym for builtin function at line 13, column 1. See page 177 of PBP. (Severity: 4) # Looks like you failed 2 tests of 19. And the output of t/auth.t doesn't look very good, although it passes: t/auth.............# Don't know how to open browser for system 'linux' at t/auth.t line 73 ok Thanks in advance for looking into this issue! Cheers, gregor (Debian Perl Group) -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Bob Dylan: Workingmans's Blues

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Sun Oct 19 23:14:10 2008 david.romano [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #40152] Test failures in 0.4.14
Date:	Sun, 19 Oct 2008 20:13:51 -0700
To:	gregor herrmann via RT <bug-WWW-Facebook-API [...] rt.cpan.org>
From:	David Romano <david.romano [...] gmail.com>

Hi Gregor, gregor herrmann via RT wrote on Sat, Oct 18, 2008 at 09:29:55AM PDT: Show quoted text

> two perlcritic tests fail for 0.4.14: > > ...

I've fixed these in the latest version in git...a new release will happen at some point. Apologies for that. Show quoted text

> And the output of t/auth.t doesn't look very good, although it passes: > > t/auth.............# Don't know how to open browser for system 'linux' at t/auth.t line 73 > ok

Basically, I don't know of a consistent way to open a browser under linux, so the test doesn't fail (and it's really only for desktop apps). I only know of gnome-open, but that assumes GNOME is installed. If you have any ideas, let us know, - David -- "Science does not aim at establishing immutable truths and eternal dogmas: its aim is to approach the truth by successive approximations, without claiming that at any stage final and complete accuracy has been achieved." -- Bertrand Russell, The ABC of Relativity

Sun Oct 19 23:14:12 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Oct 20 14:12:32 2008 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #40152] Test failures in 0.4.14
Date:	Mon, 20 Oct 2008 20:11:46 +0200
To:	"david.romano [...] gmail.com via RT" <bug-WWW-Facebook-API [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Sun, 19 Oct 2008 23:14:12 -0400, david.romano@gmail.com via RT wrote: Show quoted text

> > two perlcritic tests fail for 0.4.14: > > > > ...

> I've fixed these in the latest version in git...a new release will > happen at some point. Apologies for that.

Thanks for the quick fix! Show quoted text

> > And the output of t/auth.t doesn't look very good, although it passes: > > > > t/auth.............# Don't know how to open browser for system 'linux' at t/auth.t line 73 > > ok

> Basically, I don't know of a consistent way to open a browser under > linux, so the test doesn't fail (and it's really only for desktop apps). > I only know of gnome-open, but that assumes GNOME is installed. If you > have any ideas, let us know,

xdg-open would be an alternative; but I guess it wouldn't really help in my case where I build the module in a chroot anyway :) It's not really a problem, it just doesn't look nice ... Maybe making it optional with an environment variable in the test script would be an option? Cheers, gregor -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Neil Young: Sail Away

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Mon Oct 20 14:30:53 2008 clayton.scott [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #40152] Test failures in 0.4.14
Date:	Mon, 20 Oct 2008 14:30:21 -0400
To:	bug-WWW-Facebook-API [...] rt.cpan.org
From:	"Clayton Scott" <clayton.scott [...] gmail.com>

Or SKIP the test if you don't know how to perform the operation on the given platform. On Mon, Oct 20, 2008 at 2:12 PM, gregor herrmann via RT < bug-WWW-Facebook-API@rt.cpan.org> wrote: Show quoted text

> Queue: WWW-Facebook-API > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=40152 > > > On Sun, 19 Oct 2008 23:14:12 -0400, david.romano@gmail.com via RT wrote: >

> > > two perlcritic tests fail for 0.4.14: > > > > > > ...

> > I've fixed these in the latest version in git...a new release will > > happen at some point. Apologies for that.

> > Thanks for the quick fix! >

> > > And the output of t/auth.t doesn't look very good, although it passes: > > > > > > t/auth.............# Don't know how to open browser for system 'linux'

> at t/auth.t line 73

> > > ok

> > Basically, I don't know of a consistent way to open a browser under > > linux, so the test doesn't fail (and it's really only for desktop apps). > > I only know of gnome-open, but that assumes GNOME is installed. If you > > have any ideas, let us know,

> > xdg-open would be an alternative; but I guess it wouldn't really help > in my case where I build the module in a chroot anyway :) > > It's not really a problem, it just doesn't look nice ... > Maybe making it optional with an environment variable in the test > script would be an option? > > Cheers, > gregor > -- > .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: > 0x00F3CFE4 > : :' : Debian GNU/Linux user, admin, & developer - > http://www.debian.org/ > `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | > http://got.to/quote/ > `- NP: Neil Young: Sail Away > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkj8yeIACgkQOzKYnQDzz+SI9wCdEO44/MEwm9yftoYs1PHYkeFQ > kesAoPQ1afHrmhyMQuw2pYWZVnTVksBA > =1jrg > -----END PGP SIGNATURE----- > >

-- Clayton Scott clayton.scott@gmail.com

Sat Nov 28 19:30:34 2009 unobe [...] cpan.org - Status changed from 'open' to 'resolved'