Bug #40144 for Net-SSLeay: Failing tests on *BSD; assumption about sockaddr contents

Sat Oct 18 02:20:00 2008 dmn [...] debian.org - Ticket created

Subject:	Failing tests on *BSD; assumption about sockaddr contents
Date:	Sat, 18 Oct 2008 09:19:36 +0300
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Damyan Ivanov <dmn [...] debian.org>

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Hi, A Debian GNU/kFreeBSD porter, Petr Salinger reported the following bug[1] against the Debian package. [1] http://bugs.debian.org/502518 Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in replies. --------------------------- the current version fails to build on GNU/kFreeBSD. It is due to failed tests. Unfortunately, tests assume some variant of "struct sockaddr". This variant is not used on BSD* systems. The linux one have at the beginning "short family", but BSD* systems have "char length; char family". It looks like it would be better to use sockaddr_in() for constructing needed parameters. With the patch bellow the test suite passes on GNU/kFreeBSD. It would be nice if you can inform upstream about this problem, there are also needed similar changes in examples. --------------------------- The patch attached addresses "pack vs. sockaddr_in" only for tests. The examples could get a bit of porting effort too. Thanks, dam Debian Perl Group -- dam JabberID: dam@jabber.minus273.org

Message body is not shown because sender requested not to inline it.

Wed Oct 22 03:55:24 2008 mikem [...] open.com.au - Correspondence added

CC:	502518 [...] bugs.debian.org, 502518-submitter [...] bugs.debian.org
Subject:	Re: [rt.cpan.org #40144] Failing tests on *BSD; assumption about sockaddr contents
Date:	Wed, 22 Oct 2008 17:54:50 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hello, thanks for reporting this. Your patch has been applied to SVN and will appear in the next release. Cheers. On Saturday 18 October 2008 16:20, dmn@debian.org via RT wrote: Show quoted text

> Sat Oct 18 02:20:00 2008: Request 40144 was acted upon. > Transaction: Ticket created by dmn@debian.org > Queue: Net-SSLeay > Subject: Failing tests on *BSD; assumption about sockaddr contents > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: dmn@debian.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=40144 > > > > Hi, > > A Debian GNU/kFreeBSD porter, Petr Salinger reported the following > bug[1] against the Debian package. > > [1] http://bugs.debian.org/502518 > > Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in > replies. > > --------------------------- > the current version fails to build on GNU/kFreeBSD. > > It is due to failed tests. Unfortunately, tests assume some variant of > "struct sockaddr". This variant is not used on BSD* systems. The linux > one have at the beginning "short family", but BSD* systems have "char > length; char family". > > It looks like it would be better to use sockaddr_in() for constructing > needed parameters. With the patch bellow the test suite passes on > GNU/kFreeBSD. > > It would be nice if you can inform upstream about this problem, there > are also needed similar changes in examples. > --------------------------- > > The patch attached addresses "pack vs. sockaddr_in" only for tests. > The examples could get a bit of porting effort too. > > Thanks, > dam > Debian Perl Group

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Oct 22 03:55:29 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Dec 10 17:10:41 2008 SREZIC [...] cpan.org - Correspondence added

On Sat Oct 18 02:20:00 2008, dmn@debian.org wrote: Show quoted text

> Hi, > > A Debian GNU/kFreeBSD porter, Petr Salinger reported the following > bug[1] against the Debian package. > > [1] http://bugs.debian.org/502518 > > Please Cc 502518@bugs.debian.org, 502518-submitter@bugs.debian.org in > replies. > > --------------------------- > the current version fails to build on GNU/kFreeBSD. > > It is due to failed tests. Unfortunately, tests assume some variant of > "struct sockaddr". This variant is not used on BSD* systems. The linux > one have at the beginning "short family", but BSD* systems have "char > length; char family". > > It looks like it would be better to use sockaddr_in() for constructing > needed parameters. With the patch bellow the test suite passes on > GNU/kFreeBSD. > > It would be nice if you can inform upstream about this problem, there > are also needed similar changes in examples. > --------------------------- > > The patch attached addresses "pack vs. sockaddr_in" only for tests. > The examples could get a bit of porting effort too. >

For everybody's convenience, I uploaded the patch to $CPAN/authors/id/S/SR/SREZIC/patches/Net-SSLeay-1.35-PetrSalinger-01.patch so it is available when using CPAN.pm's distroprefs. E.g. like this: match: distribution: "/Net-SSLeay-1\.35\.tar\.gz" perlconfig: osname: freebsd osvers: "^[789]\." patches: - SREZIC/patches/Net-SSLeay-1.35-PetrSalinger-01.patch ... Regards, Slaven

Sat Jan 30 16:41:13 2010 rafl [...] debian.org - Status changed from 'open' to 'resolved'