Bug #40113 for Astro-satpass: Moon rise and set calculation problems

Thu Oct 16 20:05:55 2008 michael_t [...] gazeta.pl - Ticket created

Hello, I try to get moonrise and moonset times, but it gives me false details and about week in the future. Here is my script: #!/usr/bin/perl -w use Astro::Coord::ECI; use Astro::Coord::ECI::Moon; my $lat=54.58; my $long=18.39; my $alt=0; my $moon = Astro::Coord::ECI::Moon->new (); my $sta = Astro::Coord::ECI->universal(time() )->geodetic ($lat, $long, $alt); my ($time, $rise) = $sta->next_elevation ($moon); print scalar localtime (time),"\n"; print "Moon @{[$rise ? 'rise' : 'set']} is ",scalar localtime $time,"\n"; and here is result: Fri Oct 17 01:56:01 2008 Moon rise is Wed Oct 29 15:32:24 2008 according to: http://aa.usno.navy.mil/data/docs/RS_OneYear.php its not even proper time for 29th of Oct. Is there an error in my script? I did like it was in excample at http://search.cpan.org/~wyant/Astro-satpass-0.018/lib/Astro/Coord/ECI/ Moon.pm ... or is it a bug in Astro::Coord::ECI::Moon. All the best, Michael Tocha

Thu Oct 16 21:47:23 2008 wyant [...] cpan.org - Subject changed from (no value) to 'Moon rise and set calculation problems'

Thu Oct 16 22:04:08 2008 wyant [...] cpan.org - Correspondence added

I think that, strictly speaking, there is a bug in your script, though the fact that my example is not complete certainly helped you write the bug. Given that I bootstrap myself into new software by working through examples all the time, it amazes me how many bugs I find in my examples. The missing thing from the example is that the latitude and longitude are to be given in radians, not degrees. This was a conscious design decision made because I was not smart enough to decide which routines would be used internally in the future, and I was too lazy to provide "degree" routines and "radian" routines. Saying that it was a conscious decision is not defending it as right, but it is saying that it is probably far too late to change. What I recommend doing to your script is to use Astro::Coord::ECI::Utils qw{deg2rad}; and then call that to convert the latitude and longitude to radians. I have attached a modified version of your script that does this. So at the very least the example needs changing. Maybe I could also limit-check the arguments, since a latitude of 54.58 radians is clearly bogus.

Download sample
application/octet-stream 556b

Message body not shown because it is not plain text.

Thu Oct 16 22:04:11 2008 The RT System itself - Status changed from 'new' to 'open'

Fri Oct 17 08:30:35 2008 michael_t [...] gazeta.pl - Correspondence added

From:

michael_t [...] gazeta.pl

Thankyou for quick response, of course everything works like it should :)

Mon Oct 27 23:01:45 2008 wyant [...] cpan.org - Correspondence added

Astro-satpass-0.019 has been uploaded, and should appear on the various mirrors in the next few hours/days. Except for Active State's PPM repository, which appears to be running rather behind. Most of the code examples in the SYNOPSIS section have been modified to be actual working scripts rather than code fragments. A couple of them (Astro::Coord::ECI::Star comes to mind) were not even close to being right. I made a real effort to make sure all the example code ran as-is. I'll probably leave the ticket open another week or so (or until I remember it again) for feedback. And until the rt system learns about version 0.019 so I can mark the bug fixed in that release.

Wed Oct 29 18:06:06 2008 wyant [...] cpan.org - Fixed in 0.019 added

Fri Nov 14 14:17:26 2008 wyant [...] cpan.org - Correspondence added

On Mon Oct 27 23:01:45 2008, WYANT wrote: Show quoted text

> > I'll probably leave the ticket open another week or so (or until I > remember it again) for feedback. And until the rt system learns about > version 0.019 so I can mark the bug fixed in that release.

It's been two weeks without anything on _this_ ticket (though see 40899 for a related problem), so I'm marking this resolved.

Fri Nov 14 14:17:35 2008 wyant [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #40113 for Astro-satpass: Moon rise and set calculation problems

Preferred bug tracker