Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Devel-CheckOS CPAN distribution.

Report information
The Basics
Id: 40011
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Devel-CheckOS

People
Owner: dcantrell [...] cpan.org
Requestors: ishigaki [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: t/00_checkos.t fails due to an uncanonical path
Hi. t/00_checkos.t of Devel-CheckOS-1.44 fails under Windows due to an uncanonical filename (with forward and back slashes in it). Not sure if the attached patch is the best fix (it may be better to fix the test) but anyway I hope this helps. Thanks. Kenichi Ishigaki
Subject: Devel-CheckOS-1.44.patch
diff -ur Devel-CheckOS-1.44/lib/Devel/CheckOS.pm Devel-CheckOS-1.44-patched/lib/Devel/CheckOS.pm --- Devel-CheckOS-1.44/lib/Devel/CheckOS.pm Fri Sep 26 23:28:43 2008 +++ Devel-CheckOS-1.44-patched/lib/Devel/CheckOS.pm Mon Oct 13 23:38:49 2008 @@ -188,7 +188,7 @@ } { module => join('::', @dirs, $file_part), - file => $_ + file => File::Spec->canonpath($_) } } File::Find::Rule->file()->name('*.pm')->in( grep { -d }
On Mon Oct 13 10:51:24 2008, ISHIGAKI wrote: Show quoted text
> Hi. t/00_checkos.t of Devel-CheckOS-1.44 fails under Windows due to an > uncanonical filename (with forward and back slashes in it). Not sure if > the attached patch is the best fix (it may be better to fix the test) > but anyway I hope this helps. Thanks.
Better to fix the code, I think, so that it always generates platform-friendly paths. I assume that your fix will also correct any accidental broken-ness on platforms like VMS. Thanks, applied.