Bug #39916 for Data-Peek: Perl_sv_peek, and the failure of test

Thu Oct 09 08:21:18 2008 taro.nishino [...] gmail.com - Ticket created

Subject:

Perl_sv_peek, and the failure of test

Dear H.Merijn Brand, My perl is ActivePerl Build 817, which doesn't have Perl_sv_peek(I think). As such, the linking was failure. So, I copied the source of Perl_sv_peek from dump.c into Peek.xs. Unfortunately, although its build was success, its test was failure as follows: C:\test\Perl\Data-Peek-0.20>nmake test Microsoft(R) Program Maintenance Utility Version 7.00.9955 Copyright (C) Microsoft Corporation. All rights reserved. C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl ib\lib', 'blib\arch')" t/*.t t/00_pod........ok t/01_pod........ok t/10_DDumper....ok t/20_DPeek......ok t/30_DDump-s....1/6 # Failed test 'DDump (undef)' # at t/30_DDump-s.t line 54. # got: 'SV = PV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY) # PV = 0 # ' # expected: 'SV = PV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY) # PV = 0 # ' # Failed test 'DDump (0)' # at t/30_DDump-s.t line 54. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 0 # PV = 0 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 0 # PV = 0 # ' # Failed test 'DDump (1)' # at t/30_DDump-s.t line 54. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 1 # PV = 0 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 1 # PV = 0 # ' # Failed test 'DDump ("")' # at t/30_DDump-s.t line 54. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,POK,pPOK) # IV = 1 # PV = 0x**** ""\0 # CUR = 0 # LEN = 8 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,POK,pPOK) # IV = 1 # PV = 0x**** ""\0 # CUR = 0 # LEN = 8 # ' # Looks like you failed 4 tests of 6. t/30_DDump-s.... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/6 subtests t/31_DDump-s....ok t/40_DDump-h....ok t/41_DDump-h....ok t/50_DDual......ok Test Summary Report ------------------- t/30_DDump-s (Wstat: 1024 Tests: 6 Failed: 4) Failed tests: 3-6 Non-zero exit status: 4 t/50_DDual (Wstat: 0 Tests: 69 Failed: 0) TODO passed: 8-9, 31-32, 40-41, 49-50, 58-59, 61-64 66-69 Files=9, Tests=172, 5 wallclock secs ( 0.17 usr + 0.03 sys = 0.20 CPU) Result: FAIL Failed 1/9 test programs. 4/172 subtests failed. NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff' Stop. In my opinion, this would be due to the code of newline. Best regards, Taro Nishino

Thu Oct 09 09:33:24 2008 h.m.brand [...] xs4all.nl - Correspondence added

CC:	taro.nishino [...] gmail.com
Subject:	Re: [rt.cpan.org #39916] Perl_sv_peek, and the failure of test
Date:	Thu, 9 Oct 2008 15:32:50 +0200
To:	bug-Data-Peek [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Thu, 09 Oct 2008 08:21:22 -0400, "Taro Nishino via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text

> Thu Oct 09 08:21:18 2008: Request 39916 was acted upon. > Transaction: Ticket created by taro-nishino > Queue: Data-Peek > Subject: Perl_sv_peek, and the failure of test > Broken in: 0.20 > Severity: Important > Owner: Nobody > Requestors: taro.nishino@gmail.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=39916 > > > > Dear H.Merijn Brand, > > My perl is ActivePerl Build 817, which doesn't have Perl_sv_peek (I think).

It does, but it isn't exported :( Same problem will probably happen on AIX. sv_peek () (and perl_sv_peek ()) are in the perl API since 5.005_00 Show quoted text

> As such, the linking was failure. So, I copied the source of Perl_sv_peek from > dump.c into Peek.xs.

Hmm, evil thoughts here. I could automate that :) Keep an eye on the repository, I might try to do that. Other feedback? Show quoted text

> Unfortunately, although its build was success, its > test was failure as follows:

What build is 817? 5.8.5? Show quoted text

> C:\test\Perl\Data-Peek-0.20>nmake test > > Microsoft(R) Program Maintenance Utility Version 7.00.9955 > Copyright (C) Microsoft Corporation. All rights reserved. > > C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl > ib\lib', 'blib\arch')" t/*.t > t/00_pod........ok > t/01_pod........ok > t/10_DDumper....ok > t/20_DPeek......ok > t/30_DDump-s....1/6 > # Failed test 'DDump (undef)' > # at t/30_DDump-s.t line 54. > # got: 'SV = PV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY) > # PV = 0 > # ' > # expected: 'SV = PV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY) > # PV = 0 > # ' > > # Failed test 'DDump (0)' > # at t/30_DDump-s.t line 54. > # got: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,IOK,pIOK) > # IV = 0 > # PV = 0 > # ' > # expected: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,IOK,pIOK) > # IV = 0 > # PV = 0 > # ' > > # Failed test 'DDump (1)' > # at t/30_DDump-s.t line 54. > # got: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,IOK,pIOK) > # IV = 1 > # PV = 0 > # ' > # expected: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,IOK,pIOK) > # IV = 1 > # PV = 0 > # ' > > # Failed test 'DDump ("")' > # at t/30_DDump-s.t line 54. > # got: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,POK,pPOK) > # IV = 1 > # PV = 0x**** ""\0 > # CUR = 0 > # LEN = 8 > # ' > # expected: 'SV = PVIV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY,POK,pPOK) > # IV = 1 > # PV = 0x**** ""\0 > # CUR = 0 > # LEN = 8 > # ' > # Looks like you failed 4 tests of 6. > t/30_DDump-s.... Dubious, test returned 4 (wstat 1024, 0x400) > Failed 4/6 subtests > t/31_DDump-s....ok > t/40_DDump-h....ok > t/41_DDump-h....ok > t/50_DDual......ok > > Test Summary Report > ------------------- > t/30_DDump-s (Wstat: 1024 Tests: 6 Failed: 4) > Failed tests: 3-6 > Non-zero exit status: 4 > t/50_DDual (Wstat: 0 Tests: 69 Failed: 0) > TODO passed: 8-9, 31-32, 40-41, 49-50, 58-59, 61-64 > 66-69 > Files=9, Tests=172, 5 wallclock secs ( 0.17 usr + 0.03 sys = 0.20 CPU) > Result: FAIL > Failed 1/9 test programs. 4/172 subtests failed. > NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff' > Stop. > > > > In my opinion, this would be due to the code of newline.

That was my impression too. Easy to fix. http://repo.or.cz/w/Data-Peek.git http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Thu Oct 09 09:33:26 2008 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 09 10:48:07 2008 taro.nishino [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #39916] Perl_sv_peek, and the failure of test
Date:	Thu, 09 Oct 2008 23:47:51 +0900
To:	bug-Data-Peek [...] rt.cpan.org
From:	Taro Nishino <taro.nishino [...] gmail.com>

On Thu, 09 Oct 2008 09:33:26 -0400 "h.m.brand@xs4all.nl via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text

> > Dear H.Merijn Brand, > > > > My perl is ActivePerl Build 817, which doesn't have Perl_sv_peek (I think).

> > It does, but it isn't exported :( Same problem will probably happen on > AIX. >

Thanks a lot. I see. Show quoted text

> sv_peek () (and perl_sv_peek ()) are in the perl API since 5.005_00 >

> > As such, the linking was failure. So, I copied the source of Perl_sv_peek from > > dump.c into Peek.xs.

> > Hmm, evil thoughts here. I could automate that :) > Keep an eye on the repository, I might try to do that. > > Other feedback? >

If any, I'd like to report feedback. Show quoted text

> > Unfortunately, although its build was success, its > > test was failure as follows:

> > What build is 817? 5.8.5? >

Sorry for my bad command of English. I just said about the compilation of Data-Peek. Incidentally, My perl is ActivePerl Build 817, which is Perl5.8.8. Show quoted text

> > In my opinion, this would be due to the code of newline.

> > That was my impression too. Easy to fix. > > http://repo.or.cz/w/Data-Peek.git > http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz >

Thanks a lot. Best regards, Taro Nishino

Thu Oct 09 12:46:25 2008 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #39916] Perl_sv_peek, and the failure of test
Date:	Thu, 9 Oct 2008 18:46:06 +0200
To:	bug-Data-Peek [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Thu, 09 Oct 2008 10:48:09 -0400, "Taro Nishino via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text

> > > My perl is ActivePerl Build 817, which doesn't have Perl_sv_peek (I think).

> > > > It does, but it isn't exported :( Same problem will probably happen on AIX.

> > Thanks a lot. I see. >

> > sv_peek () (and perl_sv_peek ()) are in the perl API since 5.005_00 > >

> > > As such, the linking was failure. So, I copied the source of Perl_sv_peek from > > > dump.c into Peek.xs.

> > > > Hmm, evil thoughts here. I could automate that :) > > Keep an eye on the repository, I might try to do that.

That proves to be near to impossible, as you need the excerpts from dump.c that exactly match your version of perl. 5.11.0 tables cannot be used in other perl's. Show quoted text

> > Other feedback?

> > If any, I'd like to report feedback. >

> > > Unfortunately, although its build was success, its > > > test was failure as follows:

> > > > What build is 817? 5.8.5?

> > Sorry for my bad command of English. I just said about the compilation > of Data-Peek. > Incidentally, My perl is ActivePerl Build 817, which is Perl5.8.8. >

> > > In my opinion, this would be due to the code of newline.

> > > > That was my impression too. Easy to fix. > > > > http://repo.or.cz/w/Data-Peek.git > > http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz

Documented now how you can disable DPeek () -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Thu Oct 09 15:27:49 2008 taro.nishino [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #39916] Perl_sv_peek, and the failure of test
Date:	Fri, 10 Oct 2008 04:27:34 +0900
To:	bug-Data-Peek [...] rt.cpan.org
From:	Taro Nishino <taro.nishino [...] gmail.com>

On Thu, 09 Oct 2008 12:46:27 -0400 "h.m.brand@xs4all.nl via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=39916 > > > On Thu, 09 Oct 2008 10:48:09 -0400, "Taro Nishino via RT" <bug-Data-Peek@rt.cpan.org> wrote: >

> > > > My perl is ActivePerl Build 817, which doesn't have Perl_sv_peek (I think).

> > > > > > It does, but it isn't exported :( Same problem will probably happen on AIX.

> > > > Thanks a lot. I see. > >

> > > sv_peek () (and perl_sv_peek ()) are in the perl API since 5.005_00 > > >

> > > > As such, the linking was failure. So, I copied the source of Perl_sv_peek from > > > > dump.c into Peek.xs.

> > > > > > Hmm, evil thoughts here. I could automate that :) > > > Keep an eye on the repository, I might try to do that.

> > That proves to be near to impossible, as you need the excerpts from > dump.c that exactly match your version of perl. 5.11.0 tables cannot be > used in other perl's. >

> > > Other feedback?

> > > > If any, I'd like to report feedback. > >

> > > > Unfortunately, although its build was success, its > > > > test was failure as follows:

> > > > > > What build is 817? 5.8.5?

> > > > Sorry for my bad command of English. I just said about the compilation > > of Data-Peek. > > Incidentally, My perl is ActivePerl Build 817, which is Perl5.8.8. > >

> > > > In my opinion, this would be due to the code of newline.

> > > > > > That was my impression too. Easy to fix. > > > > > > http://repo.or.cz/w/Data-Peek.git > > > http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz

> > Documented now how you can disable DPeek () >

Thanks a lot. I disabled DPeek () using NO_SV_PEEK=1 and then the compilation was success. But, the test was failure as follows: C:\temp\Data-Peek>nmake test Microsoft(R) Program Maintenance Utility Version 7.00.9955 Copyright (C) Microsoft Corporation. All rights reserved. C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl ib\lib', 'blib\arch')" t/*.t t/00_pod........ok t/01_pod........ok t/10_DDumper....ok t/20_DPeek......skipped: Your perl did not export Perl_sv_peek () t/30_DDump-s....1/5 # Failed test 'DDump (undef)' # at t/30_DDump-s.t line 57. # got: 'SV = PV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY) # PV = 0 # ' # expected: 'SV = PV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY) # PV = 0 # ' # Failed test 'DDump (0)' # at t/30_DDump-s.t line 57. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 0 # PV = 0 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 0 # PV = 0 # ' # Failed test 'DDump (1)' # at t/30_DDump-s.t line 57. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 1 # PV = 0 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,IOK,pIOK) # IV = 1 # PV = 0 # ' # Failed test 'DDump ("")' # at t/30_DDump-s.t line 57. # got: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,POK,pPOK) # IV = 1 # PV = 0x**** ""\0 # CUR = 0 # LEN = 8 # ' # expected: 'SV = PVIV(0x****) at 0x**** # REFCNT = 1 # FLAGS = (PADMY,POK,pPOK) # IV = 1 # PV = 0x**** ""\0 # CUR = 0 # LEN = 8 # ' # Looks like you failed 4 tests of 5. t/30_DDump-s.... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/5 subtests t/31_DDump-s....ok t/40_DDump-h....ok t/41_DDump-h....ok t/50_DDual......ok Test Summary Report ------------------- t/30_DDump-s (Wstat: 1024 Tests: 5 Failed: 4) Failed tests: 2-5 Non-zero exit status: 4 t/50_DDual (Wstat: 0 Tests: 69 Failed: 0) TODO passed: 8-9, 31-32, 40-41, 49-50, 58-59, 61-64 66-69 Files=9, Tests=122, 3 wallclock secs ( 0.16 usr + 0.08 sys = 0.23 CPU) Result: FAIL Failed 1/9 test programs. 4/122 subtests failed. NMAKE : fatal error U1077: 'C:\Perl\bin\perl.exe' : return code '0xff' Stop. Best regards, Taro Nishino

Mon Oct 13 07:42:04 2008 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #39916] Perl_sv_peek, and the failure of test
Date:	Mon, 13 Oct 2008 13:41:40 +0200
To:	bug-Data-Peek [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Thu, 09 Oct 2008 15:27:51 -0400, "Taro Nishino via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text

> C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl > ib\lib', 'blib\arch')" t/*.t > t/00_pod........ok > t/01_pod........ok > t/10_DDumper....ok > t/20_DPeek......skipped: Your perl did not export Perl_sv_peek () > t/30_DDump-s....1/5 > # Failed test 'DDump (undef)' > # at t/30_DDump-s.t line 57. > # got: 'SV = PV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY) > # PV = 0 > # ' > # expected: 'SV = PV(0x****) at 0x**** > # REFCNT = 1 > # FLAGS = (PADMY) > # PV = 0 > # '

I was able to reproduce under Win-XP with Strawberry perl Now fixed in 0.21 file: $CPAN/authors/id/H/HM/HMBRAND/Data-Peek-0.21.tgz size: 49718 bytes md5: f0bbc763acad161e4a4aa6315596d159 Thanks again for your reports -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Wed Oct 22 03:43:22 2008 HMBRAND [...] cpan.org - Fixed in 0.21 added

Wed Oct 22 03:43:23 2008 HMBRAND [...] cpan.org - Status changed from 'open' to 'resolved'