Skip Menu |

This queue is for tickets about the Catalyst-Authentication-Credential-OpenID CPAN distribution.

Report information
The Basics
Id: 39688
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Catalyst-Authentication-Credential-OpenID

People
Owner: ashley [...] cpan.org
Requestors: blom [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.08
Fixed in: (no value)



Subject: Redirection failing
Hello Ashley, C::A::C::OpenID seems to be failing on my setup, due to the fact that the redirection isn't handled correctly. Since a 'return' is used, Catalyst will happily continue with the code and (in the POD example) fail. Meaning, it'll skip the redirect to the openid provider and go straight to the error form. The patch is simple. I've merely added a $c->detach(), to tell Catalyst to stop messing with other code and handle the redirect immediately. I'm using: Catalyst version 5.7014 HTH -- B10m
Subject: C-A-C-OpenID.patch
--- Catalyst-Authentication-Credential-OpenID-0.08/lib/Catalyst/Authentication/Credential/OpenID.pm Sat Jul 5 22:13:06 2008 +++ Catalyst-Authentication-Credential-OpenID-0.08_01/lib/Catalyst/Authentication/Credential/OpenID.pm Mon Sep 29 18:57:42 2008 @@ -8,7 +8,7 @@ __PACKAGE__->mk_accessors(qw/ _config realm debug secret /); } -our $VERSION = "0.08"; +our $VERSION = "0.08_01"; use Net::OpenID::Consumer; use Catalyst::Exception (); @@ -78,7 +78,7 @@ delayed_return => 1, ); $c->res->redirect($check_url); - return; + $c->detach; } elsif ( $c->req->params->{'openid-check'} ) {
Thanks much for pointing this out. I should have caught it myself but I was recycling some non-Cat code of mine and not paying attention. -Ashley
Should have mentioned: 0.09 is on its way.
Just re-closing, ticket got re-opened on last update.