Skip Menu |

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 39679
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: Sergiy.Borodych [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 4.34
  • 4.35
  • 4.36
Fixed in: (no value)



Subject: some code reuse and additional checks in remove() [CGI/Session/Driver/file.pm]
IMHO this code in remove() can be reused # diff /usr/lib/perl5/vendor_perl/5.8.8/CGI/Session/Driver/file.pm.orig /usr/lib/perl5/vendor_perl/5.8.8/CGI/Session/Driver/file.pm 127,130c127 < < my $directory = $self->{Directory}; < my $file = sprintf( $FileName, $sid ); < my $path = File::Spec->catfile($directory, $file); --- Show quoted text
> my $path = $self->_file($sid);
also it use some checks in _file after 4.34 it may usefull (secutity fix) -- Sergiy Borodych
Hi Sergiy Thanx for noticing this. A patch has been applied to SVN.
Releasing tonight.