Skip Menu |

This queue is for tickets about the WWW-Facebook-API CPAN distribution.

Report information
The Basics
Id: 39567
Status: resolved
Priority: 0/
Queue: WWW-Facebook-API

People
Owner: Nobody in particular
Requestors: TBURKE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.4.13
Fixed in: 0.4.14



Subject: Feed get_registered_template_bundle fails w/o bundle id
The ternary check in get_registered_template_bundle does not correctly catch the no-bundle_id instance, so feed.getRegisteredTemplateBundles is never called. It might also be worthwhile to point out in the documentation that the bundle code requires a server URI of http://api.new.facebook.com/restserver.php
Subject: feed.t.patch
--- t/feed.t 2008-07-23 18:49:10.000000000 -0400 +++ t/feed.t.new 2008-09-23 23:52:55.000000000 -0400 @@ -4,7 +4,7 @@ # $Author: david.romano $ # ex: set ts=8 sw=4 et ######################################################################### -use Test::More tests => 3; +use Test::More tests => 5; use WWW::Facebook::API; use strict; use warnings; @@ -24,3 +24,10 @@ is_deeply $api->feed->publish_templatized_action( actor_id => 2, title_template => '' ), [ 'feed.publishTemplatizedAction', actor_id => 2, title_template => '' ], 'publish_templatized_action calls correctly'; +is_deeply $api->feed->get_registered_template_bundle( ), + [ 'feed.getRegisteredTemplateBundles' ], + 'get_registered_template_bundle calls correctly'; +is_deeply $api->feed->get_registered_template_bundle( template_bundle_id => 1 ), + [ 'feed.getRegisteredTemplateBundleById', template_bundle_id => 1 ], + 'get_registered_template_bundle calls correctly'; +
Subject: Feed.pm.patch
--- lib/WWW/Facebook/API/Feed.pm 2008-07-30 21:19:41.000000000 -0400 +++ lib/WWW/Facebook/API/Feed.pm.new 2008-09-23 23:52:35.000000000 -0400 @@ -26,7 +26,7 @@ sub get_registered_template_bundle { my $method = - @_ + @_ > 1 ? 'feed.getRegisteredTemplateBundleById' : 'feed.getRegisteredTemplateBundles';
Thanks for the patches. I will try to get a release out before the end of this week. - Clayton
The patch is applied in v0.4.14. Which has been released to CPAN Thanks again, Clayton