Bug #39559 for Perl6-Signature: Fails to parse :(Foo|Bar $x)

Tue Sep 23 19:56:12 2008 rafl [...] debian.org - Ticket created

Subject:

Fails to parse :(Foo|Bar $x)

:(Foo|Bar $x) isn't parsed correctly. Currently :(Foo Bar $x) does what I expect :(Foo|Bar $x) to do. At git://git.perldition.org/Perl6-Signature you find a git repository that fixes this issue. In case you don't like git the patches are also available at http://git.perldition.org/?p=Perl6-Signature.git;a=summary

Sat Sep 27 11:09:25 2008 GAAL [...] cpan.org - Correspondence added

On Tue Sep 23 19:56:12 2008, FLORA wrote: Show quoted text

> :(Foo|Bar $x) isn't parsed correctly. Currently :(Foo Bar $x) does what > I expect :(Foo|Bar $x) to do. > > At git://git.perldition.org/Perl6-Signature you find a git repository > that fixes this issue. In case you don't like git the patches are also > available at http://git.perldition.org/?p=Perl6-Signature.git;a=summary

Hi Florian, Thanks for the patch! Feel free to just commit the fix (you'll need a commit bit from #moose). If that's a hassle to you, I'll check it in on your behalf. Please also add parse failure tests for :(Int| $x) and :(|Int $x).

Sat Sep 27 11:09:26 2008 The RT System itself - Status changed from 'new' to 'open'

Sat Sep 27 11:09:28 2008 GAAL [...] cpan.org - Given to GAAL

Sat Sep 27 12:49:55 2008 rafl [...] debian.org - Correspondence added

On Sat Sep 27 11:09:25 2008, GAAL wrote: Show quoted text

> Thanks for the patch! Feel free to just commit the fix (you'll need a > commit bit from #moose). If that's a hassle to you, I'll check it in on > your behalf.

Done. Show quoted text

> Please also add parse failure tests for :(Int| $x) and :(|Int $x).

While doing so I noticed that there are several ways ->parse fails. Some parse errors die, other unparsable input just makes it return undef. Shall I also unify that while I'm at it?

Sat Sep 27 12:52:53 2008 GAAL [...] cpan.org - Correspondence added

On Sat Sep 27 12:49:55 2008, FLORA wrote: Show quoted text

> On Sat Sep 27 11:09:25 2008, GAAL wrote:

> > Thanks for the patch! Feel free to just commit the fix (you'll need a > > commit bit from #moose). If that's a hassle to you, I'll check it in on > > your behalf.

> > Done. >

> > Please also add parse failure tests for :(Int| $x) and :(|Int $x).

> > While doing so I noticed that there are several ways ->parse fails. Some > parse errors die, other unparsable input just makes it return undef. > Shall I also unify that while I'm at it?

Yes, have fails die please. (If this were Perl 6, we'd have fails fail, of course.)

Sat Sep 27 13:08:10 2008 rafl [...] debian.org - Correspondence added

On Sat Sep 27 12:52:53 2008, GAAL wrote: Show quoted text

> Yes, have fails die please. (If this were Perl 6, we'd have fails fail, > of course.)

Commited. Would you mind making a release so I can make MooseX::Method::Signatures depend on it? I could do that for you if you want me to. Also, FYI, while working on MooseX::Method::Signatures, I discovered quite a few other glitches in the current parser, which I intend to work on too.

Sat Sep 27 13:11:34 2008 GAAL [...] cpan.org - Correspondence added

On Sat Sep 27 13:08:10 2008, FLORA wrote: Show quoted text

> On Sat Sep 27 12:52:53 2008, GAAL wrote:

> > Yes, have fails die please. (If this were Perl 6, we'd have fails fail, > > of course.)

> > Commited. > > Would you mind making a release so I can make MooseX::Method::Signatures > depend on it? I could do that for you if you want me to. > > Also, FYI, while working on MooseX::Method::Signatures, I discovered > quite a few other glitches in the current parser, which I intend to work > on too.

Thanks! I'll release a package tomorrow.

Wed Oct 01 16:18:03 2008 rafl [...] debian.org - Correspondence added

On Sat Sep 27 13:11:34 2008, GAAL wrote: Show quoted text

> Thanks! I'll release a package tomorrow.

Any news on this?

Wed Oct 01 19:00:28 2008 GAAL [...] cpan.org - Correspondence added

On Wed Oct 01 16:18:03 2008, FLORA wrote: Show quoted text

> On Sat Sep 27 13:11:34 2008, GAAL wrote:

> > Thanks! I'll release a package tomorrow.

> > Any news on this?

Thanks for the reminder. Perl6-Signature-0.03 uploaded to PAUSE.

Wed Oct 01 19:00:30 2008 GAAL [...] cpan.org - Status changed from 'open' to 'resolved'