Skip Menu |

This queue is for tickets about the podlators CPAN distribution.

Report information
The Basics
Id: 39542
Status: resolved
Priority: 0/
Queue: podlators

People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.1.4
Fixed in: 2.2.0



Subject: [PATCH] Spelling errors causing 'make test' to fail
'make test' is failing due to the following spelling errors: podlators-2.1.4 > perl -Mblib t/pod-spelling.t 1..8 not ok 1 - Misspelled words found in blib/script/pod2man backwards ok 2 not ok 3 - Misspelled words found in blib/lib/Pod/Man.pm towards not ok 4 - Misspelled words found in blib/lib/Pod/ParseLink.pm backwards ok 5 ok 6 ok 7 ok 8 The attached patch corrects these.
Subject: patch.txt
--- podlators-2.1.4/scripts/pod2man.PL +++ podlators-2.1.4/scripts/pod2man.PL @@ -58,7 +58,7 @@ my $stdin; @ARGV = map { $_ eq '-' && !$stdin++ ? ('--', $_) : $_ } @ARGV; -# Parse our options, trying to retain backwards compatibility with pod2man but +# Parse our options, trying to retain backward compatibility with pod2man but # allowing short forms as well. --lax is currently ignored. my %options; $options{errors} = 'pod'; @@ -78,7 +78,7 @@ my $verbose = $options{verbose}; delete $options{verbose}; -# This isn't a valid Pod::Man option and is only accepted for backwards +# This isn't a valid Pod::Man option and is only accepted for backward # compatibility. delete $options{lax}; @@ -193,7 +193,7 @@ No longer used. B<pod2man> used to check its input for validity as a manual page, but this should now be done by L<podchecker(1)> instead. Accepted for -backwards compatibility; this option no longer does anything. +backward compatibility; this option no longer does anything. =item B<-n> I<name>, B<--name>=I<name> --- podlators-2.1.4/lib/Pod/Man.pm +++ podlators-2.1.4/lib/Pod/Man.pm @@ -1646,7 +1646,7 @@ There is currently no way to turn off the guesswork that tries to format unmarked text appropriately, and sometimes it isn't wanted (particularly when using POD to document something other than Perl). Most of the work -towards fixing this has now been done, however, and all that's still needed +toward fixing this has now been done, however, and all that's still needed is a user interface. The NAME section should be recognized specially and index entries emitted --- podlators-2.1.4/lib/Pod/ParseLink.pm +++ podlators-2.1.4/lib/Pod/ParseLink.pm @@ -141,7 +141,7 @@ of the parsing, as is any leading or trailing whitespace. If the text of the LE<lt>E<gt> escape is entirely enclosed in double quotes, -it's interpreted as a link to a section for backwards compatibility. +it's interpreted as a link to a section for backward compatibility. No attempt is made to resolve formatting codes. This must be done after calling parselink() (since EE<lt>E<gt> formatting codes can be used to
Subject: Re: [rt.cpan.org #39542] [PATCH] Spelling errors causing 'make test' to fail
Date: Tue, 23 Sep 2008 10:39:01 -0700
To: bug-podlators [...] rt.cpan.org
From: Russ Allbery <rra [...] stanford.edu>
"Jerry D. Hedden via RT" <bug-podlators@rt.cpan.org> writes: Show quoted text
> 'make test' is failing due to the following spelling errors: > > podlators-2.1.4 > perl -Mblib t/pod-spelling.t > 1..8 > not ok 1 > - Misspelled words found in blib/script/pod2man > backwards > ok 2 > not ok 3 > - Misspelled words found in blib/lib/Pod/Man.pm > towards > not ok 4 > - Misspelled words found in blib/lib/Pod/ParseLink.pm > backwards > ok 5 > ok 6 > ok 7 > ok 8 > > The attached patch corrects these.
I agree with the patch, but the weird part is that this didn't show up for me. On both a Debian testing system and on an RHEL 4 system, backwards and towards are accepted as valid words by both ispell and aspell. Interesting. Thank you for the patch! I'll apply this for the next version (and probably also disable spelling checks for people other than the maintainer, since they appear to be remarkably fragile). -- Russ Allbery (rra@stanford.edu) <http://www.eyrie.org/~eagle/>
Subject: Re: [rt.cpan.org #39542] [PATCH] Spelling errors causing 'make test' to fail
Date: Tue, 23 Sep 2008 17:07:09 -0400
To: bug-podlators [...] rt.cpan.org
From: "Jerry D. Hedden" <jdhedden [...] cpan.org>
Show quoted text
> Thank you for the patch! I'll apply this for the next version (and > probably also disable spelling checks for people other than the > maintainer, since they appear to be remarkably fragile).
I do just that with the module I maintain. For example: use Test::More; if ($ENV{RUN_MAINTAINER_TESTS}) { plan 'tests' => 3; } else { plan 'skip_all' => 'Module maintainer tests'; }
Spelling changes applied, and as of 2.2.0, podlators no longer runs the spelling checks except for the maintainer.