Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the XSLoader CPAN distribution.

Report information
The Basics
Id: 39520
Status: resolved
Priority: 0/
Queue: XSLoader

People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.09
Fixed in: 0.10



Subject: Incorrect check for Test::Pod::Coverage version in t/podcover.t
Even though I'm using Test::Pod::Coverage 1.08, 'make test' produces the following: t/podcover....skipped: Test::Pod::Coverage 1.04 required for testing POD coverage Attached is a patch to fix this issue.
Subject: patch.txt
--- XSLoader-0.09/t/podcover.t +++ XSLoader-0.09/t/podcover.t @@ -2,8 +2,9 @@ use strict; use Test::More; -plan skip_all => "Test::Pod::Coverage 1.04 required for testing POD coverage" - unless eval "use Test::Pod::Coverage 1.04"; +eval "use Test::Pod::Coverage 1.04"; +plan skip_all => "Test::Pod::Coverage 1.04 or later required for testing POD coverage" + if $@; plan tests => 1; pod_coverage_ok(XSLoader => {also_private => ['^bootstrap_inherit$']});
Subject: Re: [rt.cpan.org #39520] Incorrect check for Test::Pod::Coverage version in t/podcover.t
Date: Mon, 22 Sep 2008 23:21:00 +0200
To: bug-XSLoader [...] rt.cpan.org
From: Sébastien Aperghis-Tramoni <saper [...] cpan.org>
Jerry D. Hedden wrote: Show quoted text
> Even though I'm using Test::Pod::Coverage 1.08, 'make test' > produces the > following: > > t/podcover....skipped: Test::Pod::Coverage 1.04 required for > testing > POD coverage > > Attached is a patch to fix this issue. > --- XSLoader-0.09/t/podcover.t > +++ XSLoader-0.09/t/podcover.t > @@ -2,8 +2,9 @@ > use strict; > use Test::More; > > -plan skip_all => "Test::Pod::Coverage 1.04 required for testing > POD coverage" > - unless eval "use Test::Pod::Coverage 1.04"; > +eval "use Test::Pod::Coverage 1.04"; > +plan skip_all => "Test::Pod::Coverage 1.04 or later required for > testing POD coverage" > + if $@;
In fact, the correct way to write such code is do_something if eval "use Whatever; 1"; because there is more than one way to overwrite $@. But I indeed forgot to return 1 from the eval. Thanks for noticing this. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.