Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 39509
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: mhasch-cpanbugs [...] cozap.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.82
Fixed in: (no value)



Subject: LWP::Simple not listed in prerequisites, and used without explicit permission
I don't know when Module::CPANTS::Kwalitee::Distros.pm was added to the distro -- it is not mentioned in Changes --, but as of 0.82 it uses LWP::Simple, which is not listed among the prerequisites in META.yml. Not having LWP::Simple installed will break the test suite as well as cpants_lint.pl. I'd rather like to opt-in to Internet downloads when analyzing modules anyway, so not requiring any download tools would be a good thing. You could check whether the module is present before you use it. Please add a configuration parameter defaulting to "no downloads" while you are at it. -Martin
On Mon Sep 22 07:40:32 2008, MHASCH wrote: Show quoted text
> I don't know when Module::CPANTS::Kwalitee::Distros.pm was added to the > distro -- it is not mentioned in Changes --, but as of 0.82 it uses > LWP::Simple, which is not listed among the prerequisites in META.yml.
Missing prereq added at https://github.com/daxim/Module-CPANTS-Analyse/pull/11
Thanks for the report. The metric that used LWP::Simple is gone now. Closed as resolved. On Mon Sep 22 23:40:32 2008, MHASCH wrote: Show quoted text
> I don't know when Module::CPANTS::Kwalitee::Distros.pm was added to the > distro -- it is not mentioned in Changes --, but as of 0.82 it uses > LWP::Simple, which is not listed among the prerequisites in META.yml. > > Not having LWP::Simple installed will break the test suite as well as > cpants_lint.pl. I'd rather like to opt-in to Internet downloads when > analyzing modules anyway, so not requiring any download tools would be a > good thing. You could check whether the module is present before you > use it. Please add a configuration parameter defaulting to "no > downloads" while you are at it. > > -Martin