Bug #39285 for Apache-WebDAV: DELETE doesn't seem to work on collection trees

Mon Sep 15 05:38:51 2008 peter [...] makholm.net - Ticket created

Subject:

DELETE doesn't seem to work on collection trees

The delete method uses File::Find::Rule::Filesys::Virtual to get a list of ressources to delete. For collections this will in general place collections before content. But Apache::WebDAV tries to delete ressources in the order File::Find::Rule::Filesys::Virtual returns them. Which means that i tries to delete collection before the content is deleted, which often fails (at least with Filesys::Virtual::Plain). This bug also breaks COPY as this is implemented by an copy/delete operation.

Mon Sep 15 07:20:48 2008 peter [...] makholm.net - Correspondence added

From:

peter [...] makholm.net

On Mon Sep 15 05:38:51 2008, pmakholm wrote: Show quoted text

> This bug also breaks COPY as this is implemented by an copy/delete > operation.

This should have been MOVE instead of COPY. Fixing the delete-method only fixes the DELETE operation. MOVE uses an copy pasted version of the method called delete_resource.

Mon Sep 15 08:11:48 2008 peter [...] makholm.net - Correspondence added

From:

peter [...] makholm.net

On Mon Sep 15 05:38:51 2008, pmakholm wrote: Show quoted text

> The delete method uses File::Find::Rule::Filesys::Virtual to get a list > of ressources to delete. For collections this will in general place > collections before content.

Both the delete method and the delete_resource method contains the following code: my @files = grep {$_ !~ m|/\.\.?$|} # Make sure it's not a / . .. map { s|/+|/|g; $_ } # Replace multiple slashes with single File::Find::Rule::Filesys::Virtual->virtual($handler)->in($file), $file; A quick fix is to change both places to add an reverse in front of the grep operator and to change the order of $file and the File::Find::Rule in the third line. I don't know if FFRF::Virtual guarantees a pre-order traversal of the directory tree. If this isn't guaranteed the solution would be to sort the output on the length of the paths.