Skip Menu |

This queue is for tickets about the CPANPLUS CPAN distribution.

Report information
The Basics
Id: 39247
Status: resolved
Priority: 0/
Queue: CPANPLUS

People
Owner: Nobody in particular
Requestors: SHLOMIF [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.85_04
Fixed in: (no value)



Subject: [PATCH] Convert wrong "it's" to "its"
Hi all! As I grepped through the CPANPLUS sources I noticed one "it's" where "its should do". So I wrote a patch to convert all the appropriate "it's"s into "its"s. Here it is against CPANPLUS-0.85_04. Please apply it. Regards, Shlomi Fish
Subject: cpanplus-it-apostrphe-s.patch
--- ./bin/cpan2dist.orig 2008-09-13 15:42:23.694286918 +0300 +++ ./bin/cpan2dist 2008-09-13 15:14:11.441037359 +0300 @@ -272,7 +272,7 @@ my $obj; ### is it a tarball or dir?? then we get it locally and transform it - ### and it's dependencies into .debs + ### and its dependencies into .debs if( $archive ) { ### make sure we use an absolute path, so chdirs() dont ### mess things up @@ -436,7 +436,7 @@ specified on the command line, and all their prerequisites. Can also create a distribution of type FMT from a local - archive and all it's prerequisites + archive and all of its prerequisites. =cut @@ -522,11 +522,11 @@ Examples: - ### build a debian package of DBI and it's prerequisites, + ### build a debian package of DBI and its prerequisites, ### don't bother running tests cpan2dist --format CPANPLUS::Dist::Deb --buildprereq --skiptest DBI - ### build a debian package of DBI and it's prerequisites and install them + ### build a debian package of DBI and its prerequisites and install them cpan2dist --format CPANPLUS::Dist::Deb --buildprereq --install DBI ### Build a package, whose format is determined by your config, of @@ -539,7 +539,7 @@ ### patterns mentioned in /tmp/ban cpan2dist --ban Foo --ban Bar --banlist /tmp/ban Net::FTP - ### build a package from Net::FTP, but ignore it's listed dependency + ### build a package from Net::FTP, but ignore its listed dependency ### on IO::Socket, as it's shipped per default with the OS we're on cpan2dist --ignore IO::Socket Net::FTP --- ./inc/bundle/Archive/Extract.pm.orig 2008-09-13 15:42:23.697286785 +0300 +++ ./inc/bundle/Archive/Extract.pm 2008-09-13 15:14:57.475039821 +0300 @@ -239,11 +239,11 @@ Since C<.gz> files never hold a directory, but only a single file; if the C<to> argument is an existing directory, the file is extracted -there, with it's C<.gz> suffix stripped. +there, with its C<.gz> suffix stripped. If the C<to> argument is not an existing directory, the C<to> argument is understood to be a filename, if the archive type is C<gz>. In the case that you did not specify a C<to> argument, the output -file will be the name of the archive file, stripped from it's C<.gz> +file will be the name of the archive file, stripped from its C<.gz> suffix, in the current working directory. C<extract> will try a pure perl solution first, and then fall back to @@ -504,7 +504,7 @@ ### double hateful: bunzip2 --version also hangs if input is a pipe ### See #32370: Archive::Extract will hang if stdin is a pipe [+PATCH] ### So, we have to provide *another* argument which is a fake filename, - ### just so it wont try to read from stdin to print it's version.. + ### just so it wont try to read from stdin to print its version.. ### *sigh* ### Even if the file exists, it won't clobber or change it. my $buffer; --- ./lib/CPANPLUS/Dist/Base.pm.orig 2008-09-13 15:42:23.702286826 +0300 +++ ./lib/CPANPLUS/Dist/Base.pm 2008-09-13 15:12:48.059228696 +0300 @@ -99,7 +99,7 @@ $dist->status->mk_accessors( qw[my_implementation_accessor] ); The C<status> object is implemented as an instance of the -C<Object::Accessor> class. Please refer to it's documentation for +C<Object::Accessor> class. Please refer to its documentation for details. Return true if the initialization was successul, and false if it was --- ./lib/CPANPLUS/Internals/Source.pm.orig 2008-09-13 15:42:23.708286787 +0300 +++ ./lib/CPANPLUS/Internals/Source.pm 2008-09-13 15:22:59.930037562 +0300 @@ -1223,7 +1223,7 @@ #msg(loc("Index file written to '%1'", $to), $verbose); } - ### copy it to the real spot and update it's timestamp + ### copy it to the real spot and update its timestamp } else { $self->_move( file => $res, to => $local ) or return; $self->_update_timestamp( file => $local ); --- ./lib/CPANPLUS/Internals/Utils.pm.orig 2008-09-13 15:42:23.711286740 +0300 +++ ./lib/CPANPLUS/Internals/Utils.pm 2008-09-13 15:23:40.483036487 +0300 @@ -472,7 +472,7 @@ =head2 ($pkg, $version, $ext) = $cb->_split_package_string( package => PACKAGE_STRING ); -Splits the name of a CPAN package string up in it's package, version +Splits the name of a CPAN package string up into its package, version and extension parts. For example, C<Foo-Bar-1.2.tar.gz> would return the following parts: --- ./lib/CPANPLUS/Shell/Default/Plugins/HOWTO.pod.orig 2008-09-13 15:42:23.717286962 +0300 +++ ./lib/CPANPLUS/Shell/Default/Plugins/HOWTO.pod 2008-09-13 15:27:33.971810906 +0300 @@ -47,7 +47,7 @@ sub hw { print "Hello, world!\n" } When the user in the default shell now issues the C</helloworld> command, -this command will be dispatched to the plugin, and it's C<hw> method will +this command will be dispatched to the plugin, and its C<hw> method will be called =head2 Registering Plugin Help --- ./lib/CPANPLUS/Shell/Default.pm.orig 2008-09-13 15:42:23.719287264 +0300 +++ ./lib/CPANPLUS/Shell/Default.pm 2008-09-13 15:28:23.744038781 +0300 @@ -1199,7 +1199,7 @@ boxed => CONFIG_BOXED, }->{ $key } || CONFIG_USER; - ### boxed is special, so let's get it's value from %INC + ### boxed is special, so let's get its value from %INC ### so we can tell it where to save ### XXX perhaps this logic should be generic for all ### types, and put in the ->save() routine @@ -1656,7 +1656,7 @@ } } - ### dispatch a plugin command to it's function + ### dispatch a plugin command to its function sub _meta { my $self = shift; my %hash = @_; --- ./lib/CPANPLUS/Config.pm.orig 2008-09-13 15:42:23.699288003 +0300 +++ ./lib/CPANPLUS/Config.pm 2008-09-13 15:18:30.754465753 +0300 @@ -134,7 +134,7 @@ =item base -The directory CPANPLUS keeps all it's build and state information in. +The directory CPANPLUS keeps all its build and state information in. Defaults to ~/.cpanplus. =cut --- ./lib/CPANPLUS/inc.pm.orig 2008-09-13 15:42:23.705287132 +0300 +++ ./lib/CPANPLUS/inc.pm 2008-09-13 15:20:23.276038073 +0300 @@ -38,7 +38,7 @@ =head1 SYNOPSIS - ### set up CPANPLUS::inc to do it's thing ### + ### set up CPANPLUS::inc to do its thing ### BEGIN { use CPANPLUS::inc }; ### enable debugging ### --- ./lib/CPANPLUS/Module.pm.orig 2008-09-13 15:42:23.714286814 +0300 +++ ./lib/CPANPLUS/Module.pm 2008-09-13 15:26:03.232039858 +0300 @@ -1595,9 +1595,9 @@ =head2 $bool = $self->add_to_includepath; Adds the current modules path to C<@INC> and C<$PERL5LIB>. This allows -you to add the module from it's build dir to your path. +you to add the module from its build dir to your path. -You can reset C<@INC> and C<$PERL5LIB> to it's original state when you +You can reset C<@INC> and C<$PERL5LIB> to its original state when you started the program, by calling: $self->parent->flush('lib'); --- ./t/19_CPANPLUS-Dist.t.orig 2008-09-13 15:42:23.722286880 +0300 +++ ./t/19_CPANPLUS-Dist.t 2008-09-13 15:29:12.784371438 +0300 @@ -55,7 +55,7 @@ ### XXX this version doesn't exist, but we don't check for it either ### my $Prereq = { $ModPrereq => '1000' }; -### since it's in this file, not in it's own module file, +### since it's in this file, not in its own module file, ### make M::L::C think it already was loaded $Module::Load::Conditional::CACHE->{$Module}->{usable} = 1;
On Sat Sep 13 08:49:52 2008, SHLOMIF wrote: Show quoted text
> As I grepped through the CPANPLUS sources I noticed one "it's" where > "its should do". So I wrote a patch to convert all the appropriate > "it's"s into "its"s.
Thanks, applied.