Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Locale-Maketext-Lexicon CPAN distribution.

Report information
The Basics
Id: 39158
Status: resolved
Priority: 0/
Queue: Locale-Maketext-Lexicon
People
Owner: Nobody in particular
Requestors: dam [...] modsoftsys.com
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)
Attachments
02more_TT_whitespace_flags.patch
signature.asc

History Show all quoted text
  Wed Sep 10 10:59:11 2008 http://real-dam.myopenid.com/ - Ticket created
Subject: Extract.pm: more whitespace stripping options to TT tags
I see [%-|l-%] sort of tags are already supported in v0.68. Could it be possible for all the white space stripping tag modifiers to be supported? That'd be +, =, ~ (and '-', which is already supported). Attached is a patch to do this. For reference, see Template::Manual::Config (search for 'Tag Modifier') Thanks in advance.
Subject: 02more_TT_whitespace_flags.patch
--- a/lib/Locale/Maketext/Extract.pm +++ b/lib/Locale/Maketext/Extract.pm @@ -255,7 +255,7 @@ sub extract { # Template Toolkit $line = 1; pos($_) = 0; - while (m!\G(.*?\[%-?\s*\|l(?:oc)?(.*?)\s*(-?)%\](.*?)\[%(-?)\s*END\s*-?%\])!sg) { + while (m!\G(.*?\[%[-=~+]?\s*\|l(?:oc)?(.*?)\s*([-=~+]?)%\](.*?)\[%([-=~+]?)\s*END\s*[-=~+]?%\])!sg) { my ($vars, $trim_start, $str, $trim_end) = ($2, $3, $4, $5); $line += ( () = ($1 =~ /\n/g) ); # cryptocontext! $vars =~ s/^\s*\(//;
  Mon Sep 15 09:36:28 2008 felix.ostmann [...] thewar.de - Correspondence added
From: felix.ostmann [...] thewar.de
your patch wont work! you only change the parsing-thing, but you must also change the string how he must be changed! if( $trim_start eq '-' ) ... $trim_start eq '~' ... On Mi. 10. Sep. 2008, 10:59:11, http://real-dam.myopenid.com/ wrote: Show quoted text
> I see [%-|l-%] sort of tags are already supported in v0.68. Could it be > possible for all the white space stripping tag modifiers to be > supported? That'd be +, =, ~ (and '-', which is already supported). > > Attached is a patch to do this. > > For reference, see Template::Manual::Config (search for 'Tag Modifier') > > Thanks in advance.
  Mon Sep 15 09:36:30 2008 The RT System itself - Status changed from 'new' to 'open'
  Tue Oct 28 15:20:18 2008 develop [...] traveljury.com - Correspondence added
On Wed Sep 10 10:59:11 2008, http://real-dam.myopenid.com/ wrote: Show quoted text
> I see [%-|l-%] sort of tags are already supported in v0.68. Could it be > possible for all the white space stripping tag modifiers to be > supported? That'd be +, =, ~ (and '-', which is already supported). >
The TT parser has been completely rewritten, and now supports anything that TT supports. clint
  Tue Oct 28 15:50:22 2008 dam [...] modsoftsys.com - Correspondence added
Subject: Re: [rt.cpan.org #39158] Extract.pm: more whitespace stripping options to TT tags
Date: Tue, 28 Oct 2008 21:49:55 +0200
To: Clinton Gormley via RT <bug-Locale-Maketext-Lexicon [...] rt.cpan.org>
From: Damyan Ivanov <dam [...] modsoftsys.com>
-=| Clinton Gormley via RT, Tue, Oct 28, 2008 at 03:20:20PM -0400 |=- Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=39158 > > > On Wed Sep 10 10:59:11 2008, http://real-dam.myopenid.com/ wrote:
> > I see [%-|l-%] sort of tags are already supported in v0.68. Could it be > > possible for all the white space stripping tag modifiers to be > > supported? That'd be +, =, ~ (and '-', which is already supported).
> > The TT parser has been completely rewritten, and now supports anything > that TT supports.
Right. This bug report can now be closed. Thank you! -- dam JabberID: dam@jabber.minus273.org
Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

  Wed Oct 29 04:55:08 2008 develop [...] traveljury.com - Correspondence added
On Tue Oct 28 15:50:22 2008, dam@modsoftsys.com wrote: Show quoted text
> -=| Clinton Gormley via RT, Tue, Oct 28, 2008 at 03:20:20PM -0400 |=-
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=39158 > > > > > On Wed Sep 10 10:59:11 2008, http://real-dam.myopenid.com/ wrote:
> > > I see [%-|l-%] sort of tags are already supported in v0.68. Could
it be Show quoted text
> > > possible for all the white space stripping tag modifiers to be > > > supported? That'd be +, =, ~ (and '-', which is already supported).
> > > > The TT parser has been completely rewritten, and now supports anything > > that TT supports.
> > Right. This bug report can now be closed. > > > Thank you! >
  Wed Oct 29 04:55:11 2008 develop [...] traveljury.com - Status changed from 'open' to 'resolved'