| Subject: | LWP and dependency fine tuning |
| Date: | Wed, 10 Sep 2008 13:37:37 +1200 |
| To: | bug-XML-Entities [...] rt.cpan.org |
| From: | Lloyd Parkes <Lloyd.Parkes [...] ird.govt.nz> |
Hi,
While packaging this module up for use by pkgsrc on Solaris, I encountered a
couple of problems with the dependency on LWP.
The Makefile.PL for XML::Entities lists a dependecy on LWP::Simple. The code
actually uses LWP::UserAgent, and not LWP::Simple.
I also added a line to make the LWP::UserAgent call env_proxy(). Without this,
people on networks with web proxies will be unable to build the module. This
doesn't cause a problem on networks without web proxies.
Cheers
--
Lloyd Parkes
Senior Systems Programmer
Open Systems
Ph: +64 4 890 2437
$NetBSD$
--- /home/lloyd/pkgwork/ir/p5-XML-Entities/work/XML-Entities/Makefile.PL.orig 2008-05-15 03:19:32.000000000 +1200
+++ /home/lloyd/pkgwork/ir/p5-XML-Entities/work/XML-Entities/Makefile.PL
@@ -26,7 +26,7 @@ WriteMakefile(
'Carp' => 0,
'Test::More' => 0,
'File::Basename' => 0,
- 'LWP::Simple' => 0,
+ 'LWP::UserAgent' => 0,
'Fatal' => 0,
},
dist => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', },
$NetBSD$
--- /home/lloyd/pkgwork/ir/p5-XML-Entities/work/XML-Entities/bin/download-entities.pl.orig 2008-07-23 23:04:56.000000000 +1200
+++ /home/lloyd/pkgwork/ir/p5-XML-Entities/work/XML-Entities/bin/download-entities.pl
@@ -18,6 +18,7 @@ my $out_fn = $ENV{OUTPUT_FILE};
my $index_url;
my %OPTIONS = ();
my $LWP_USER_AGENT = LWP::UserAgent->new;
+$LWP_USER_AGENT->env_proxy;
if ($ENV{INTERACTIVE}) {
$OPTIONS{interactive} = 1;