Show quoted text>>>>> On Sat, 13 Sep 2008 09:36:45 -0400, "Andy Armstrong via RT" <bug-Test-Harness@rt.cpan.org> said:
> On Sat Sep 06 02:05:09 2008, ANDK wrote:
>> Somewhere between 3.09 and 3.13 the parsing of skip lines changed. The
>> following is in my test file:
>> BEGIN {
>> print "1..0 # Skip: test only run when called with --doit\n";
>> }
>>
>> Parsed by 3.09 gives:
>> t/14forkbomb......skipped: test only run when called with --doit
>>
>>
>> But 3.13:
>> t/14forkbomb....skipped: (no reason given)
>>
>>
>> I just read the spec and I'd say this is a bug in TH now. I've checked
>> current SVN and it's still the same.
>>
>> Thanks,
> That's because a skip plan is supposed to look like
Show quoted text > 1..0 # SKIP I can't go on like this...
Show quoted text > We decided that if the skip syntax wasn't quite right we'd still skip but couldn't reliably
> extract the description (because people do things like # Skipping ...)
I cannot help but this is the wording of the TAP spec and I cannot
read your interpretation out of it. So please fix the abmiguous wording.
Skipping tests
If the directive starts with # SKIP, the test is counted as having
To support you wording, this would have to be something like:
...starts with /^# skip /i ...
been skipped. If the whole test file succeeds, the count of
skipped tests is included in the generated output. The harness
should report the text after # SKIP\S*\s+ as a reason for
Look here, suddenly the spec does know about regular expressions but
to a different result than above and not yet telling anything about
case sensitivity.
skipping.
ok 23 # skip Insufficient flogiston pressure.
And now the spec reveals that there is case insensitivity.
Similarly, one can include an explanation in a plan line, emitted
if the test file is skipped completely:
1..0 # Skipped: WWW::Mechanize not installed
And now the confusion is perfect and the spec lets shine through that
other words than "skip" itself are allowed.
Could you please bring spec and code in accordance?
--
andreas
