Bug #38727 for Module-CPANTS-Analyse: Use strict test does not recognise use Moose

Tue Aug 26 06:19:17 2008 Support [...] RoxSoft.co.uk - Ticket created

Subject:

Use strict test does not recognise use Moose

The tests for use strict and use warnings do not recognise use Moose and use Moose::Role as being equivalent. Attached a patch to fix this

Subject:

uses.patch

--- Uses.pm 2008-08-26 10:31:04.000000000 +0100 +++ Uses.pm 2008-08-26 10:37:57.000000000 +0100 @@ -81,11 +81,15 @@ my ($strict)=$uses->{'strict'}; my ($moose)=$uses->{'Moose'}; - return 0 unless $strict; + my ($moose_role)=$uses->{'Moose::Role'}; + return 0 unless $strict or $moose or $moose_role; my $total = $strict->{in_code}; if ($moose) { $total += $moose->{in_code}; } + if ($moose_role) { + $total += $moose_role->{in_code}; + } return 1 if $total >= @$modules; return 0; }, @@ -101,8 +105,17 @@ my $uses=$d->{uses}; return 0 unless $modules && $uses; my ($warnings)=$uses->{'warnings'}; - return 0 unless $warnings; - return 1 if $warnings->{in_code} >= @$modules; + my ($moose)=$uses->{'Moose'}; + my ($moose_role)=$uses->{'Moose::Role'}; + return 0 unless $warnings or $moose or $moose_role; + my $total = $warnings->{in_code}; + if ($moose) { + $total += $moose->{in_code}; + } + if ($moose_role) { + $total += $moose_role->{in_code}; + } + return 1 if $total >= @$modules; return 0; }, },

Wed Oct 21 17:32:38 2009 cjm [...] cpan.org - Correspondence added

Here's an improved version of the patch. It adds MooseX::Types to the list of modules that add strict & warnings. It also uses a loop, so it's easy to add more.

--- Module/CPANTS/Kwalitee/Uses.pm 2009-10-21 13:03:58.000000000 -0500 +++ Module/CPANTS/Kwalitee/Uses.pm 2009-10-21 16:30:01.595332228 -0500 @@ -78,14 +78,12 @@ my $modules=$d->{modules}; my $uses=$d->{uses}; return 0 unless $modules && $uses; - - my ($strict)=$uses->{'strict'}; - my ($moose)=$uses->{'Moose'}; - return 0 unless $strict; - my $total = $strict->{in_code}; - if ($moose) { - $total += $moose->{in_code}; - } + + my $total = 0; + foreach my $package (qw(strict Moose Moose::Role MooseX::Types)) { + my ($pkg_uses)=$uses->{$package}; + $total += $pkg_uses->{in_code} if $pkg_uses; + } # end foreach $package that provides strictness return 1 if $total >= @$modules; return 0; }, @@ -100,9 +98,13 @@ my $modules=$d->{modules}; my $uses=$d->{uses}; return 0 unless $modules && $uses; - my ($warnings)=$uses->{'warnings'}; - return 0 unless $warnings; - return 1 if $warnings->{in_code} >= @$modules; + + my $total = 0; + foreach my $package (qw(warnings Moose Moose::Role MooseX::Types)) { + my ($pkg_uses)=$uses->{$package}; + $total += $pkg_uses->{in_code} if $pkg_uses; + } # end foreach $package that provides warnings + return 1 if $total >= @$modules; return 0; }, },

Wed Oct 21 17:32:40 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 21 17:33:25 2009 cjm [...] cpan.org - Requestor CJM added

Wed Oct 21 17:34:03 2009 cjm [...] cpan.org - Status changed from 'open' to 'new'

Tue Jan 24 06:23:26 2012 abraxxa [...] cpan.org - Correspondence added

Am Mi 21. Okt 2009, 17:32:38, CJM schrieb: Show quoted text

> Here's an improved version of the patch. It adds MooseX::Types to the > list of modules that add strict & warnings. It also uses a loop, so > it's easy to add more.

MooseX::Types does *not* enable use strict: A MooseX::Types is just a normal Perl module. Unlike Moose itself, it does not install use strict and use warnings in your class by default, so this is up to you.

Tue Jan 24 06:23:28 2012 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 24 08:06:36 2012 cjm [...] cpan.org - Correspondence added

On Tue, Jan 24, 2012 5:23:26 AM, ABRAXXA wrote: Show quoted text

> MooseX::Types does *not* enable use strict: > > A MooseX::Types is just a normal Perl module. Unlike Moose itself, it > does not install use strict and use warnings in your class by default, > so this is up to you.

Starting with MooseX::Types 0.04 it most certainly does enable strict and warnings. From its Changes: 0.04 2007-08-09 - Automatically set strict and warnings like Moose does From its import method: # everyone should want this strict->import; warnings->import;

Sun Apr 01 07:57:38 2012 daxim [...] cpan.org - Correspondence added

fixed on github

Sun Apr 01 07:57:40 2012 daxim [...] cpan.org - Status changed from 'open' to 'resolved'