Bug #38697 for Net-Pcap: Patch to generalize t/03 test

Sun Aug 24 16:04:38 2008 he [...] NetBSD.org - Ticket created

Subject:	Patch to generalize t/03 test
Date:	Sun, 24 Aug 2008 22:04:18 +0200 (CEST)
To:	bug-Net-Pcap [...] rt.cpan.org
From:	Havard Eidnes <he [...] NetBSD.org>

Hi, while adapting the update of this packae from 0.14 to 0.16 in NetBSD's pkgsrc system, I found that test 03 didn't know how to handle NetBSD, so the test failed. I *think* all BSD systems are the same in this respect, so this is a suggested test: --- t/03-openlive.t.orig 2007-12-22 20:46:39.000000000 +0100 +++ t/03-openlive.t @@ -64,7 +64,7 @@ eval { $pcap = Net::Pcap::open_live($fak is( $@, '', "open_live()" ); if($^O eq 'MSWin32' or $^O eq 'cygwin') { like( $err, '/^Error opening adapter:/', " - \$err must be set: $err" ); -} elsif($^O eq 'darwin' or $^O eq 'freebsd' or $^O eq 'openbsd') { +} elsif($^O eq 'darwin' or $^O =~ '.*bsd') { like( $err, "/^(?:BIOCSETIF: )?$fakedev: Device not configured/", " - \$err must be set: $err" ); } else { like( $err, '/^(?:bind|ioctl|SIOCGIFHWADDR): (?:No such device)/', " - \$err must be set: $err" ); Best regards, - Håvard

Sun Aug 24 21:03:38 2008 SAPER [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #38697] Patch to generalize t/03 test
Date:	Mon, 25 Aug 2008 03:03:22 +0200
To:	bug-Net-Pcap [...] rt.cpan.org
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Havard Eidnes wrote via RT: Show quoted text

> Hi,

Hello, Show quoted text

> while adapting the update of this packae from 0.14 to 0.16 in > NetBSD's pkgsrc system, I found that test 03 didn't know how to > handle NetBSD, so the test failed. I *think* all BSD systems are > the same in this respect, so this is a suggested test:

Thanks for the patch, but in fact, that test is just wrong. Checking for the error string is stupid because it varies with the system, with the locale, and in fact does not add anything. As would Larry say, "It was a baaaad idea!". I'll just chainsaw it in the next release. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.

Sun Aug 24 21:03:40 2008 The RT System itself - Status changed from 'new' to 'open'

Mon Aug 25 05:08:18 2008 he [...] uninett.no - Correspondence added

Subject:	Re: [rt.cpan.org #38697] Patch to generalize t/03 test
Date:	Mon, 25 Aug 2008 11:07:15 +0200 (CEST)
To:	bug-Net-Pcap [...] rt.cpan.org
From:	Havard Eidnes <he [...] uninett.no>

Show quoted text

> > while adapting the update of this packae from 0.14 to 0.16 in > > NetBSD's pkgsrc system, I found that test 03 didn't know how to > > handle NetBSD, so the test failed. I *think* all BSD systems are > > the same in this respect, so this is a suggested test:

> > Thanks for the patch, but in fact, that test is just wrong. Checking > for the error string is stupid because it varies with the system, > with the locale, and in fact does not add anything. As would Larry > say, "It was a baaaad idea!". I'll just chainsaw it in the next release.

Heh, that works for me too. :-) Regards, - Håvard

Thu Dec 06 03:00:46 2012 SAPER [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Dec 06 03:00:46 2012 SAPER [...] cpan.org - Fixed in 0.17 added