Bug #38606 for Perl-Critic: RequireFinalReturn fails to recognize valid return

> We're getting the message Subroutine does not end with "return" on > subroutines that clearly do end in "return;". After some examination, > here is the case that causes the flawed message: > > sub f { > foreach my $name qw(John Bill Bob) { > print("$name\n"); > } > return; > } > > The problem is with the construct "qw(John Bill Bob)". The problem goes > away if you put parens around that. I always thought it a bit odd that > Perl accepts this since I had assumed that surrounding parens would be > required, but Perl doesn't complain and handles it as you would expect. > But it does cause a problem with Perl::Critic.

> Wed Aug 20 09:16:15 2008: Request 38606 was acted upon. > Transaction: Ticket created by jdeighan > Queue: Perl-Critic > Subject: RequireFinalReturn fails to recognize valid return > Broken in: 1.090 > Severity: Important > Owner: Nobody > Requestors: john.deighan@gmail.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=38606 > > > > We're getting the message Subroutine does not end with "return" on > subroutines that clearly do end in "return;". After some examination, > here is the case that causes the flawed message: > > sub f { > foreach my $name qw(John Bill Bob) { > print("$name\n"); > } > return; > } > > The problem is with the construct "qw(John Bill Bob)". The problem > goes > away if you put parens around that. I always thought it a bit odd that > Perl accepts this since I had assumed that surrounding parens would be > required, but Perl doesn't complain and handles it as you would > expect. > But it does cause a problem with Perl::Critic.