Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 38511
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: mschwern [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)
Attachments
magenta.patch
perlcritic magenta on white.tiff
perlcritic yellow on white.tiff

History Show all quoted text
  Fri Aug 15 19:57:50 2008 mschwern [...] cpan.org - Ticket created
Subject: Change color for severity 4 to magenta
Yellow, which perlcritic uses to color severity level 4, is very hard to see on a white background. Magenta is easy to see on a white or black background. I've attached some screenshots to illustrate. While I understand the desire to keep "red" for most severe and "yellow" for not so severe, the yellow is hard to read on many screens. Would you please consider switching from yellow to magenta? Patch is attached.
Subject: magenta.patch
--- bin/perlcritic (revision 57937) +++ bin/perlcritic (local) @@ -456,7 +456,7 @@ my %color_of = ( $SEVERITY_HIGHEST => 'bold red', - $SEVERITY_HIGH => 'yellow', + $SEVERITY_HIGH => 'magenta', ); return map { _colorize( "$_", $color_of{$_->severity()} ) } @violations; @@ -916,7 +916,7 @@ =item C<--color> This option is on when outputting to a tty. When set, Severity 5 and 4 are -colored red and yellow, respectively. Colorization only happens if +colored red and magenta, respectively. Colorization only happens if L<Term::ANSIColor|Term::ANSIColor> is installed and it only works on non-Windows environments. Negate this switch to disable color. You can set the default value for this option in your F<.perlcriticrc> file.
Subject: perlcritic magenta on white.tiff
Download perlcritic magenta on white.tiff
image/tiff 45.2k
perlcritic magenta on white.tiff
Subject: perlcritic yellow on white.tiff
Download perlcritic yellow on white.tiff
image/tiff 46.9k
perlcritic yellow on white.tiff
  Fri Aug 15 21:17:01 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #38511] Change color for severity 4 to magenta
Date: Fri, 15 Aug 2008 20:16:48 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Michael G Schwern via RT wrote: Show quoted text
> While I understand the desire to keep "red" for most severe and "yellow" > for not so severe, the yellow is hard to read on many screens. Would > you please consider switching from yellow to magenta?
The real fix is to make the colors configurable.
  Fri Aug 15 21:17:03 2008 The RT System itself - Status changed from 'new' to 'open'
  Fri Aug 15 22:50:28 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #38511] Change color for severity 4 to magenta
Date: Fri, 15 Aug 2008 21:50:16 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Michael G Schwern via RT wrote: Show quoted text
> Yellow, which perlcritic uses to color severity level 4, is very hard to > see on a white background.
There's your problem. What kind of geek can you be if use a white background? :]
  Sun Aug 17 03:40:20 2008 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #38511] Change color for severity 4 to magenta
Date: Sun, 17 Aug 2008 00:39:39 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Elliot Shank via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=38511 > > > Michael G Schwern via RT wrote:
>> Yellow, which perlcritic uses to color severity level 4, is very hard to >> see on a white background.
Configurable or not, it would be nice if the default was something that showed up well on typical background colors. -- 7. Not allowed to add "In accordance with the prophesy" to the end of answers I give to a question an officer asks me. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
  Wed Aug 20 21:13:51 2008 jeff [...] imaginative-software.com - Correspondence added
Subject: Re: [rt.cpan.org #38511] Change color for severity 4 to magenta
Date: Wed, 20 Aug 2008 18:12:49 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
Magenta it is then. Change committed in revision 2688. We'll work on making the colors configurable some day. Jeffrey Thalhammer Imaginative Software Systems vcard: http://www.imaginative-software.com/contact/jeff.vcf On Aug 17, 2008, at 12:40 AM, Michael G Schwern via RT wrote: Show quoted text
> Queue: Perl-Critic > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=38511 > > > Elliot Shank via RT wrote:
>> <URL: http://rt.cpan.org/Ticket/Display.html?id=38511 > >> >> Michael G Schwern via RT wrote:
>>> Yellow, which perlcritic uses to color severity level 4, is very >>> hard to >>> see on a white background.
> > Configurable or not, it would be nice if the default was something > that showed > up well on typical background colors. > > > -- > 7. Not allowed to add "In accordance with the prophesy" to the end of > answers I give to a question an officer asks me. > -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. > Army > http://skippyslist.com/list/ >
  Wed Aug 20 22:50:36 2008 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #38511] Change color for severity 4 to magenta
Date: Wed, 20 Aug 2008 19:49:39 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Jeffrey Thalhammer via RT wrote: Show quoted text
> Magenta it is then. Change committed in revision 2688.
Thanks! -- On error resume stupid
  Tue Sep 02 18:31:08 2008 thaljef [...] cpan.org - Correspondence added
Fixed and released in version 1.092.
  Tue Sep 02 18:31:12 2008 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'