Skip Menu |

This queue is for tickets about the Data-Table CPAN distribution.

Report information
The Basics
Id: 38452
Status: resolved
Priority: 0/
Queue: Data-Table
People
Owner: Nobody in particular
Requestors: MVR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in:
  • 1.52
  • 1.53
  • 1.54
Fixed in: (no value)

History Show all quoted text
  Wed Aug 13 16:00:09 2008 MVR [...] cpan.org - Ticket created
Subject: Regression for "fromCSV" since 1.52
A regression crept in from 1.51 to 1.52 A PC file with EOL=CR+LF carries an extra CR when parsed as a CSV file. 1.51 = All is well, the trailing CR is consumed and does not appear as column value. Verified the good behavior was there for all versions prior as well. 1.52 = A trailign CR is retained. The issue can be fixed in 1.54 by commenting one line in Table.pm 929c929 < binmode $SRC; --- Show quoted text
> #binmode $SRC;
Please review and confirm and bless the change. Thanks, Ramana
  Wed Aug 13 16:08:40 2008 MVR [...] cpan.org - Correspondence added
A similiar fix is needed for "fromTSV" as well. 1063c1063 < binmode $SRC; --- Show quoted text
> # binmode $SRC;
  Wed Aug 13 16:08:45 2008 MVR [...] cpan.org - Status changed from 'new' to 'open'
  Sun Feb 05 02:18:14 2012 easydatabase [...] gmail.com - Correspondence added
This should not be a problem in newer versions. Either explicitly specify the file OS in fromCSV/fromTSV, or use Data::Table::fromFile, which will try to guess the right OS that has been used to create the table file. On Wed Aug 13 16:08:40 2008, MVR wrote: Show quoted text
> A similiar fix is needed for "fromTSV" as well. > > 1063c1063 > < binmode $SRC; > ---
> > # binmode $SRC;
>
  Sun Feb 05 02:18:39 2012 easydatabase [...] gmail.com - Status changed from 'open' to 'resolved'