Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 38405
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: CHORNY [...] cpan.org
Requestors: perl [...] galumph.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



CC: chromatic [...] cpan.org
Subject: Recent Module::CPANTS::Analyse breaks Test::Kwalitee.
Date: Mon, 11 Aug 2008 14:37:58 -0500
To: bug-module-cpants-analyse [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Test::Kwalitee: 0.30 (which was released 3 Mar 2006) Module::CPANTS::Analyse: 0.82 Perl: 5.10.0 OS: Darwin 9.4.0 I don't know when this problem occurred, but it was in the past several months. I've finally gotten annoyed enough to attempt to track it down. If I use these modules as is (as in "use Test::Kwalitee;"; see http://search.cpan.org/src/ELLIOTJS/PPIx-Grep-v0.0.6/xt/author/kwalitee.t), I get "need a dist at /Users/elliot/opt/perl/perl-5.10/lib/site_perl/5.10.0/Test/Kwalitee.pm line 78". Existing code in Test::Kwalitee looks like my $analyzer = Module::CPANTS::Analyse->new({ distdir => $args{basedir}, }); Thinking that the required key for the constructor is the problem (as shown in the POD for Module::CPANTS::Analyse), I hacked this code in Test::Kwalitee to look like: my $analyzer = Module::CPANTS::Analyse->new({ dist => $args{basedir}, }); This dies with "invalid top directory at /Users/elliot/opt/perl/perl-5.10/lib/5.10.0/File/Find.pm line 593." (File::Find is the stock 1.12 that's included in 5.10.0). If I then change Test::Kwalitee to look like my $analyzer = Module::CPANTS::Analyse->new({ distdir => $args{basedir}, dist => $args{basedir}, }); it works.
This issue should have been fixed since Test::Kwalitee 1.00 (released on Thu Aug 14 05:03:02 UTC 2008). Thanks. On Tue Aug 12 04:38:31 2008, clonezone wrote: Show quoted text
> Test::Kwalitee: 0.30 (which was released 3 Mar 2006) > Module::CPANTS::Analyse: 0.82 > Perl: 5.10.0 > OS: Darwin 9.4.0 > > I don't know when this problem occurred, but it was in the past > several months. I've finally gotten annoyed enough to attempt to > track it down. > > If I use these modules as is (as in "use Test::Kwalitee;"; see > http://search.cpan.org/src/ELLIOTJS/PPIx-Grep- > v0.0.6/xt/author/kwalitee.t), I get "need a dist at > /Users/elliot/opt/perl/perl- > 5.10/lib/site_perl/5.10.0/Test/Kwalitee.pm line 78". > > Existing code in Test::Kwalitee looks like > > my $analyzer = Module::CPANTS::Analyse->new({ > distdir => $args{basedir}, > }); > > Thinking that the required key for the constructor is the problem (as > shown in the POD for Module::CPANTS::Analyse), I hacked this code > in Test::Kwalitee to look like: > > my $analyzer = Module::CPANTS::Analyse->new({ > dist => $args{basedir}, > }); > > This dies with "invalid top directory at /Users/elliot/opt/perl/perl- > 5.10/lib/5.10.0/File/Find.pm line 593." (File::Find is the stock > 1.12 that's included in 5.10.0). > > If I then change Test::Kwalitee to look like > > my $analyzer = Module::CPANTS::Analyse->new({ > distdir => $args{basedir}, > dist => $args{basedir}, > }); > > it works.