Bug #3838 for File-Find-Rule: Win32: Newline problem tripping up t/File-Find-Rule.t

Mon Sep 22 11:10:05 2003 Guest - Ticket created

Subject:

Win32: Newline problem tripping up t/File-Find-Rule.t

When running nmake test on Win32, test 20 on line 159 in File-Find-Rule.t fails. It looks for file "foobar" which should be 10 bytes. It's actually 11 bytes so the file isn't found. I suspect this has to do with the trailing Windows CR-LF in the file (is it created programmatically perhaps?). Replacing the \n with a "!" (making the file become 10 bytes) made all the tests work. Suggested fix: Replace the \n in the file with some other char. I tagged this as important because since the tests fail, it's not in the ActiveState PPM repository, so I had to install it (and its dependencies) "manually". Many people on Windows don't know how to do that, so this failing test probably limits the module's reach.

Mon Sep 22 11:19:51 2003 richardc [...] unixbeard.net - Correspondence added

Date:	Mon, 22 Sep 2003 16:19:14 +0100
From:	Richard Clamp <richardc [...] unixbeard.net>
To:	Guest via RT <bug-File-Find-Rule [...] rt.cpan.org>
Subject:	Re: [cpan #3838] Win32: Newline problem tripping up t/File-Find-Rule.t
RT-Send-Cc:

On Mon, Sep 22, 2003 at 11:10:06AM -0400, Guest via RT wrote: Show quoted text

> I tagged this as important because since the tests fail, it's not in > the ActiveState PPM repository, so I had to install it (and its > dependencies) "manually". Many people on Windows don't know how to > do that, so this failing test probably limits the module's reach.

Thanks for the reminder, I'm already aware of this one. The guys at ActiveState worked around this in their build system in order to make a 0.11 PPM[0] but so far I've not adapted their fix into one more general for release, so 0.20 and 0.21 once again exhibit the bug. I'll try and get this fixed over the next few days. [0] http://ppm.activestate.com/PPMPackages/zips/8xx-builds-only/Windows/File-Find-Rule-0.11.zip -- Richard Clamp <richardc@unixbeard.net>

Wed Oct 22 13:16:57 2003 RCLAMP [...] cpan.org - Correspondence added

[richardc@unixbeard.net - Mon Sep 22 11:19:51 2003]: Show quoted text

> I'll try and get this fixed over the next few days.

I'm afraid to say that it took longer than I'd first anticipated to get around to this. I've now uploaded 0.25 to CPAN which incorporates a fix for this issue. Could you please test? -- Richard Clamp <richardc@unixbeard.net>

Wed Oct 22 18:12:07 2003 RCLAMP [...] cpan.org - Correspondence added

[johanl@bahnhof.se - Wed Oct 22 16:19:21 2003]: Show quoted text

> All tests successful.

Beautiful, thanks. -- Richard Clamp <richardc@unixbeard.net>

Wed Oct 22 18:12:08 2003 RCLAMP [...] cpan.org - Status changed from 'new' to 'resolved'