| Subject: | PoCoCl Keepalive v0.20 Bug? |
| Date: | Tue, 22 Jul 2008 11:19:41 -0600 |
| To: | bug-POE [...] rt.cpan.org |
| From: | "Dave Weston" <dtweston [...] gmail.com> |
I think the following chunk of code from around line 840 in v0.20
contains a typo:
# Skip DNS resolution if it's already a dotted quad.
# TODO - Not all dotted quads are good.
if ($host !~ /^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/) {
DEBUG_DNS and warn "DNS: $host is a dotted quad; skipping lookup";
$kernel->call("$self", ka_add_to_queue => $request);
return;
}
I think the !~ above should be an =~. Without this change, tests
02_socket_queue.t and 12_extref.t both fail.
Thanks,
Dave Weston
--
"What Andy giveth, Bill taketh away."
--Source Unknown