Bug #37752 for CGI-Session: [patch] Improved work with bits

Thu Jul 17 02:31:51 2008 latypoff [...] yandex.ru - Ticket created

Subject:	[patch] Improved work with bits
Date:	Thu, 17 Jul 2008 10:31:07 +0400
To:	bug-cgi-session [...] rt.cpan.org
From:	"Denis F. Latypoff" <latypoff [...] yandex.ru>

Currently CGI::Session uses mixed style of working with bits, attached patch solves it. -- br, Denis F. Latypoff.

Download CGI-Session-4.35.patch-bits
application/octet-stream 4k

Message body not shown because it is not plain text.

Fri Oct 31 22:01:35 2008 MARKSTOS [...] cpan.org - Taken

Fri Oct 31 22:20:40 2008 MARKSTOS [...] cpan.org - Correspondence added

Thanks for this page. To get it to apply, I had to replace the "use constant" code with the style using "sub foo ()" that was there before. This is on Perl 5.8. However, after applying it, the test named "t/find.t" failed. Would you mind applying your patch to the 4.38 release and see if this test also fails for you? Mark

Fri Oct 31 22:20:41 2008 The RT System itself - Status changed from 'new' to 'open'

Fri Oct 31 22:20:41 2008 MARKSTOS [...] cpan.org - Status changed from 'open' to 'stalled'

Fri Oct 31 22:28:48 2008 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #37752] [patch] Improved work with bits
Date:	Sat, 01 Nov 2008 13:28:37 +1100
To:	bug-CGI-Session [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Mark On Fri, 2008-10-31 at 22:20 -0400, MARKSTOS via RT wrote: Show quoted text

> Queue: CGI-Session > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=37752 > > > Thanks for this page. > > To get it to apply, I had to replace the "use constant" code with the > style using "sub foo ()" that was there before. This is on Perl 5.8. > > However, after applying it, the test named "t/find.t" failed. Would you > mind applying your patch to the 4.38 release and see if this test also > fails for you?

I need to patch t/find.t, which I wrote. I'm doing that now. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html

Fri Oct 31 22:28:49 2008 The RT System itself - Status changed from 'stalled' to 'open'

Fri Oct 31 22:51:14 2008 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #37752] [patch] Improved work with bits
Date:	Sat, 01 Nov 2008 13:51:39 +1100
To:	bug-CGI-Session [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Mark On Fri, 2008-10-31 at 22:20 -0400, MARKSTOS via RT wrote: Show quoted text

> Queue: CGI-Session > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=37752 > > > Thanks for this page. > > To get it to apply, I had to replace the "use constant" code with the > style using "sub foo ()" that was there before. This is on Perl 5.8. > > However, after applying it, the test named "t/find.t" failed. Would you > mind applying your patch to the 4.38 release and see if this test also > fails for you?

I noticed this too. I've updated t/find.t (and Changes) in SVN. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html

Fri Oct 31 22:55:37 2008 RSAVAGE [...] cpan.org - Correspondence added

Hi Mark I'm happy with Denis' patch being applied now, with your correction.

Fri Oct 31 23:08:12 2008 MARKSTOS [...] cpan.org - Correspondence added

Although I still find bitwise math confusing, this patch does appear to improve consistency, and Ron has got t/find.t working now. Ron: I'll be on irc.perl.org as 'markstos' for a bit longer if you want to chat. I'm in #cgiapp. Mark

Fri Oct 31 23:08:14 2008 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Oct 31 23:23:33 2008 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #37752] [patch] Improved work with bits
Date:	Sat, 01 Nov 2008 14:24:00 +1100
To:	bug-CGI-Session [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Mark On Fri, 2008-10-31 at 23:08 -0400, MARKSTOS via RT wrote: Show quoted text

> Queue: CGI-Session > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=37752 > > > Although I still find bitwise math confusing, this patch does appear to > improve consistency, and Ron has got t/find.t working now.

Yep. Show quoted text

> Ron: I'll be on irc.perl.org as 'markstos' for a bit longer if you want > to chat. I'm in #cgiapp.

I don't have any IRC software installed, and I've never used it, and my sound card doesn't work under Debian (although it does work under Windows), so sorry, I won't be getting back to you via IRC! Does IRC even need a sound card? -- Ron Savage ron@savage.net.au http://savage.net.au/index.html

Fri Oct 31 23:23:35 2008 The RT System itself - Status changed from 'resolved' to 'open'

Fri Oct 31 23:33:56 2008 MARKSTOS [...] cpan.org - Correspondence added

Show quoted text

> > Ron: I'll be on irc.perl.org as 'markstos' for a bit longer if you want > > to chat. I'm in #cgiapp.

> > I don't have any IRC software installed, and I've never used it,

IRC no longer has to be a geeky experience. If you can AOL messenger chat, you can use IRC. I haved Pidgin, Konversation, and Xchat all on Linux (Ubuntu). I currently use xchat. Show quoted text

> and my > sound card doesn't work under Debian (although it does work under > Windows), so sorry, I won't be getting back to you via IRC! > > Does IRC even need a sound card?

I doubt it. It has several options for notifying you, including blinking the dock and popping up notification bubbles. Sound is not necessary. Mark

Fri Oct 31 23:33:58 2008 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'