Skip Menu |

This queue is for tickets about the Win32API-Registry CPAN distribution.

Report information
The Basics
Id: 37750
Status: resolved
Priority: 0/
Queue: Win32API-Registry
People
Owner: Nobody in particular
Requestors: DDICK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.30
Fixed in: 0.33

History Show all quoted text
  Wed Jul 16 23:43:34 2008 DDICK [...] cpan.org - Ticket created
Subject: RegQueryValueEx can cause perl to crash. Patch attached
if RegQueryValueEx is used to get a value of length 0, any access of that value causes perl to crash. Patch attachedif RegQueryValueEx is used to get a value of length 0, any access of that value causes perl to crash. Patch attached. A registry value of length 0 can be created with Win32API::Registry::RegSetValueEx($key, $name, 0, Win32API::Registry::REG_SZ(), '');
  Wed Jul 16 23:47:04 2008 DDICK [...] cpan.org - Status changed from 'new' to 'open'
  Wed Jul 16 23:50:54 2008 DDICK [...] cpan.org - Correspondence added
patch included
diff -Naur old/Registry.xs new/Registry.xs --- old/Registry.xs 2008-05-22 21:35:29.000000000 +1000 +++ new/Registry.xs 2008-07-17 12:12:07.000000000 +1000 @@ -903,6 +903,7 @@ /* Traim trailing '\0' from REG*_SZ values if iolData was C<[]>: */ if( RETVAL && NULL != opData && NULL != ouType && ( REG_SZ == *ouType || REG_EXPAND_SZ == *ouType ) + && *iolData >= 1 && null_arg(ST(5)) && '\0' == opData[*iolData-1] ) --*iolData; OUTPUT: @@ -940,6 +941,7 @@ if( RETVAL && NULL != opData && NULL != ouType && ( REG_SZ == *ouType || REG_EXPAND_SZ == *ouType ) && null_arg(ST(5)) + && *iolData >= sizeof(WCHAR) && L'\0' == ((WCHAR *)opData)[(*iolData/sizeof(WCHAR))-1] ) *iolData -= sizeof(WCHAR); OUTPUT:
  Wed Jul 16 23:51:01 2008 DDICK [...] cpan.org - Status changed from 'open' to 'new'
  Sat Apr 04 08:36:56 2015 CHORNY [...] cpan.org - Status changed from 'new' to 'patched'
  Sat Apr 04 16:21:27 2015 CHORNY [...] cpan.org - Status changed from 'patched' to 'resolved'
  Sat Apr 04 16:21:29 2015 CHORNY [...] cpan.org - Fixed in 0.33 added