Bug #37672 for Perl-Critic: [Subroutines::RequireFinalReturn]

Mon Jul 14 09:27:19 2008 coke [...] cpan.org - Ticket created

For the policy [Subroutines::RequireFinalReturn], the builtin 'exec' should be added to the list of ways to end the sub safely.

Mon Jul 14 09:40:42 2008 coke [...] cpan.org - Subject changed from (no value) to '[Subroutines::RequireFinalReturn] - allow 'exec', too.'

Mon Jul 14 10:29:01 2008 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #37672]
Date:	Mon, 14 Jul 2008 09:28:35 -0500
To:	bug-Perl-Critic [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

Will Coleda via RT wrote: Show quoted text

> For the policy [Subroutines::RequireFinalReturn], the builtin 'exec' > should be added to the list of ways to end the sub safely.

Agreed. Fixed.

Mon Jul 14 10:29:10 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 22 11:48:18 2008 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #37672]
Date:	Tue, 22 Jul 2008 08:14:09 -0700
To:	bug-Perl-Critic [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

Elliot Shank via RT wrote: Show quoted text

> Will Coleda via RT wrote:

>> For the policy [Subroutines::RequireFinalReturn], the builtin 'exec' >> should be added to the list of ways to end the sub safely.

> > Agreed. Fixed.

Released in v1.090.

Thu Jul 24 20:51:11 2008 KRYDE [...] cpan.org - Correspondence added

Umm, to chuck in my 2 cents worth, I think exec returns if it can't execute the program. Eg. sub foo { exec 'nosuchprogram'; } foo(); print "didn't exec\n";

Thu Jul 24 21:44:19 2008 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #37672] [Subroutines::RequireFinalReturn] - allow 'exec', too.
Date:	Thu, 24 Jul 2008 18:44:08 -0700
To:	bug-Perl-Critic [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

Kevin Ryde via RT wrote: Show quoted text

> Umm, to chuck in my 2 cents worth, I think exec returns if it can't > execute the program.

True, but under warnings you get a fun message that you have to work around.

Thu Jan 15 22:11:50 2009 wyant [...] cpan.org - Correspondence added

This appears to me to be a freebie for the "Perl-Critic needs your help" effort. - Perl::Critic::Policy::Subroutines::RequireFinalReturn accepts an 'exec' in 1.094001. It is advertised a couple messages earlier in the thread as being fixed in 1.09.

Fri Jan 16 21:48:11 2009 KYLE [...] cpan.org - Correspondence added

On Mon Jul 14 10:29:01 2008, clonezone wrote: Show quoted text

> Will Coleda via RT wrote:

> > For the policy [Subroutines::RequireFinalReturn], the builtin 'exec' > > should be added to the list of ways to end the sub safely.

> > Agreed. Fixed.

If we're allowing 'exec', then perhaps we should also allow 'exit', 'die', and maybe 'croak' and more. kill 9, $$

Sat Jan 17 18:11:58 2009 thaljef [...] cpan.org - Correspondence added

On Fri Jan 16 21:48:11 2009, KYLE wrote: Show quoted text

> If we're allowing 'exec', then perhaps we should also allow 'exit', > 'die', and maybe 'croak' and more.

The policy already supports those, and the user can specify additional terminal functions via configuration file. This has been released as http://search.cpan.org/~elliotjs/Perl-Critic-1.094001/ Thanks. -Jeff

Sat Jan 17 18:12:10 2009 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #37672 for Perl-Critic: [Subroutines::RequireFinalReturn] - allow 'exec', too.

Preferred bug tracker