Skip Menu |

This queue is for tickets about the SQL-Translator CPAN distribution.

Report information
The Basics
Id: 3756
Status: resolved
Worked: 30 min
Priority: 0/
Queue: SQL-Translator

People
Owner: kclark [...] cpan.org
Requestors: a.sigel [...] teckpro.de
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)



Subject: SQL comment for Oracle added
SQL::Translator 0.02, SQL-Fairy perl 5.8.0 mswin To allow for comments of style CREATE TABLE_NAME ( ATTRIBUTE_NAME TABLE_TYPE META /* here ist the comment */, in addition to the working "--"-comments, I changed SQL/Translator/Parser/Oracle.pm from: comment : /^\s*(?:#|-{2}).*\n/ to: comment : comment : /^\s*(?:#|-{2}).*\n/ | /\/\*/ /[^\*]+/ /\*\// { my $val = $item[2]; chop($val); $return = $val; } and in SQL/Producer/XML.pm in sub produce from: name data_type default_value is_auto_increment to: name data_type comments default_value is_auto_increment best regards alex -- Alexander Sigel, M.A. -- Wissensmanager / Fachberater KM -- teckpro AG (www.teckpro.de) Niederlassung Köln: Odenwaldstr. 72, 51105 Köln (-Humboldt-Gremberg) Tel./Fax: 0221/8025543, Mobil 0178/3504515 a.sigel@teckpro.de --
RT-Send-CC: sqlfairy-developers [...] lists.sourceforge.net
Thanks for the alternate comment form. I wasn't aware that was legal syntax. You also pointed out that the XML wasn't spitting out the comments. Both of these changes have been incorporated into the CVS version, which is quite different from the 0.02 version you are working from. If you're interested in contributing more or keeping up with the latest, I would suggest you checkout the project from Sourceforge and look over what's happening now. The XML producer is now called "XML::SQLFairy" to make room for other versions of XML (though just "XML" is still valid -- it's just an alias to our version). ky