Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 37487
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: perl [...] galumph.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jul 07 09:45:29 2008 perl [...] galumph.com - Ticket created
CC: Matt Kraai <kraai [...] ftbfs.org>
Subject: From Debian: Does not complain about unchecked return value of say
Date: Mon, 07 Jul 2008 08:45:07 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
This is a copy of the Debian bug report at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483304. Package: libperl-critic-perl Version: 1.082-1 I think that the InputOutput::RequireCheckedSyscalls policy should complain if the return value of say isn't checked, since it complains if the return value of print isn't checked. -- Matt
  Mon Jul 07 10:01:55 2008 chris+rt [...] chrisdolan.net - Correspondence added
On Mon Jul 07 09:45:29 2008, clonezone wrote: Show quoted text
> This is a copy of the Debian bug report at http://bugs.debian.org/cgi- > bin/bugreport.cgi?bug=483304. > > Package: libperl-critic-perl > Version: 1.082-1 > > I think that the InputOutput::RequireCheckedSyscalls policy should > complain if the return value of say isn't checked, since it complains > if the return value of print isn't checked. >
If we just add "say" to the list of builtins, then this is trivial. Alternatively, should we check for 5.10 or "use feature" first?
  Mon Jul 07 10:01:56 2008 The RT System itself - Status changed from 'new' to 'open'
  Mon Jul 07 12:15:23 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #37487] From Debian: Does not complain about unchecked return value of say
Date: Mon, 07 Jul 2008 09:50:15 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Chris Dolan via RT wrote: Show quoted text
> If we just add "say" to the list of builtins, then this is trivial. > Alternatively, should we check for 5.10 or "use feature" first?
I plan on porting P::C::Document::highest_explicit_perl_version() over to PPI::Document. Also, I want to add stuff for feature there.
  Mon May 18 19:28:37 2009 frequency [...] cpan.org - Correspondence added
From: frequency [...] cpan.org
Hi there: This bug has been open for quite a long time now. I'd like to know what has been done, and if we should create a patch in Debian? Hopefully this bug has been fixed already and we can just close this :-) Thanks, Jonathan On Mon Jul 07 12:15:23 2008, clonezone wrote: Show quoted text
> Chris Dolan via RT wrote:
> > If we just add "say" to the list of builtins, then this is trivial. > > Alternatively, should we check for 5.10 or "use feature" first?
> > I plan on porting P::C::Document::highest_explicit_perl_version() over > to PPI::Document. Also, I want to add stuff for feature there.
  Mon May 18 20:37:32 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #37487] From Debian: Does not complain about unchecked return value of say
Date: Mon, 18 May 2009 19:37:06 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Jonathan Yu via RT wrote: Show quoted text
> This bug has been open for quite a long time now. I'd like to know what > has been done, and if we should create a patch in Debian? Hopefully this > bug has been fixed already and we can just close this :-)
The current development release of PPI supports say: http://search.cpan.org/~adamk/PPI-1.204_02/. However there are bugs in both that release of PPI and P::C that prevent them from working together. I believe that I've got all the bugs that are in P::C worked out, but I'm not sure whether there are still further problems that are being hidden by the PPI bug. A regression test has been added to PPI in subversion (http://fisheye2.atlassian.com/browse/cpan/trunk/PPI/t/data/08_regression/40_foreach_eval.code?r=7146), but it's up to Adam to figure out what's gone wrong. I haven't really figured out how PPI works yet, despite having added a bunch of 5.10 support to it.
  Mon Sep 07 17:08:44 2009 ELLIOTJS [...] cpan.org - Status changed from 'open' to 'patched'
  Mon Sep 07 18:01:17 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #37487] From Debian: Does not complain about unchecked return value of say
Date: Mon, 07 Sep 2009 17:00:56 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
I decided to just take the easy way out and not look for "use feature" or "use 5.010". Released in v1.105.
  Mon Sep 07 18:01:18 2009 The RT System itself - Status changed from 'patched' to 'open'
  Mon Sep 07 18:16:27 2009 ELLIOTJS [...] cpan.org - Status changed from 'open' to 'resolved'