Bug #37442 for MP3-Tag: minor patch for ID3v2.pm

Sat Jul 05 13:34:23 2008 john_binns [...] yahoo.com - Ticket created

CC:	thg [...] users.sourceforge.net
Subject:	minor patch for ID3v2.pm
Date:	Sat, 5 Jul 2008 10:34:00 -0700 (PDT)
To:	bug-MP3-Tag [...] rt.cpan.org
From:	John Binns <john_binns [...] yahoo.com>

Sorry if you get this email twice, this is my first CPAN patch so I'm not an expert in the process yet. In the version of MP3::Tag::ID3v2 which is current on CPAN (0.9710) I found a minor annoyance. Line 1795 emits a warning, which I don't need but might be useful to some. However, the next three lines print to STDOUT instead of STDERR. I had tried to silence these warnings by temporarily unsetting $SIG{__WARN__}, but because they were printed to STDOUT they would not be silenced! The attached patch fixes this problem. John

Download id3v2_print_to_warn_patch
application/octet-stream 397b

Message body not shown because it is not plain text.

Sat Jul 05 18:05:03 2008 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #37442] minor patch for ID3v2.pm
Date:	Sat, 5 Jul 2008 15:04:40 -0700
To:	John Binns via RT <bug-MP3-Tag [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Sat, Jul 05, 2008 at 01:34:24PM -0400, John Binns via RT wrote: Show quoted text

> Line 1795 emits a warning, which I don't need but might be useful to some. > > However, the next three lines print to STDOUT instead of STDERR.

Show quoted text

> I had tried to silence these warnings by temporarily unsetting $SIG{__WARN__}, but because they were printed to STDOUT they would not be silenced!

Thanks for pointing this out. >>TODO Show quoted text

> The attached patch fixes this problem.

No it does not. Please see the docs on configuration variables. Hope this helps, Ilya

Sat Jul 05 18:05:05 2008 The RT System itself - Status changed from 'new' to 'open'