Skip Menu |

This queue is for tickets about the Mail-Sendmail CPAN distribution.

Report information
The Basics
Id: 3714
Status: resolved
Priority: 0/
Queue: Mail-Sendmail

People
Owner: mivkovic [...] cpan.org
Requestors: william [...] knowmad.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.79
Fixed in: 0.79_16



Subject: Sender header is removed
I do a lot of form processing and am using the submitted email address to set the From address. My MTA is Exim and it is setup to reject messages with invalid From and/or Sender headers. Since users will occassionally type in an invalid email address, I'm getting errors when trying to send my email through the gateway. I thought I could get by with using the new Sender key that you've provided so that Exim would verify the envelope sender. Turns out that Exim wants to see the Sender header itself. Since you delete that key after extracting the fromaddr for use in the envelope, I cannot set the Sender. I suggest using another key, e.g. Envelope-Sender, to set the envelope sender so that you do not disable the ability to set the Sender header. For the meantime, I have simply uncommented the deletion of the Sender from the %mail hash. Although I have not used this header before v0.79, it seems that some folks may be relying on it and v0.79 would break their code. Of course, some folks may prefer not to put the envelope sender info into the email headers being sent. I suggest that you create a new key and do not delete the Sender key. This would make line 216 of Sendmail.pm look like the following: $fromaddr = $mail{'Envelope-Sender'} || $mail{'Sender'} || $mail{'From'} || $mailcfg{'from'}; This solution would restore the functionality of the Sender header to applications that were relying on it before v0.79, maintain compatibility with applications based on v0.79 and also allow v0.79 users that do not want the Sender header to be set to use the new Envelope-Sender key. I look forward to your feedback. Thanks, William
Date: Thu, 04 Sep 2003 09:56:45 +0200
To: bug-Mail-Sendmail [...] rt.cpan.org
From: Milivoj Ivkovic <mi [...] alma.ch>
Subject: Re: [cpan #3714] Sender header is removed
RT-Send-Cc:
Hi, Thanks for your report. I posted a reply on the CPAN site. Not sure if it is Cc'd to you. Also, thanks for indirectly letting me know about the CPAN's new bug tracking system. I didn't know it existed! Best, Milivoj Show quoted text
>Full context and any attached attachments can be found at: ><URL: https://rt.cpan.org/Ticket/Display.html?id=3714 >
From: william [...] knowmad.com
Hi Milivoj, It doesn't seem that your reply was added to the tracker. Could you repost it? Thanks, William
Date: Thu, 04 Sep 2003 13:09:09 +0200
To: bug-Mail-Sendmail [...] rt.cpan.org
From: Milivoj Ivkovic <mi [...] alma.ch>
Subject: Re: [cpan #3714] Sender header is removed
CC: william [...] knowmad.com
RT-Send-Cc:
Show quoted text
>It doesn't seem that your reply was added to the tracker. Could you >repost it?
Hm... It shows up only when I'm logged in. Here it is again as an email, which should show up on the site. 1. I agree, the header should not be removed. (I don't even remember why I had decided to remove it). 2. I don't see the need for a separate header which would be removed. I can see no legitimate reason to hide a sender address: it will not be displayed in the mailers anyway, and only be visible in the full headers. Besides, many servers add a header with the envelope sender address (Postfix seems to add Return-Receipt:). 3. In web form processing, I don't use the visitor's email as a sender address. If the address is wrong or the mailing fails for some reason, nobody will ever know that no mail could be sent. I suggest using a known-to-be-good sender address, usually of someone responsible for the site. But that is just my personal opinion of course, and your needs may be different. In short: the next release 0.79_1 will not remove the Sender header, and it will stay like this for 0.80 unless someone convinces me it is good to remove it.