Bug #37021 for Perl-Critic: perlcritcrc settings ignored

Mon Jun 23 08:44:42 2008 Mark.E.Smith [...] arnold.af.mil - Ticket created

Subject:	perlcritcrc settings ignored
Date:	Mon, 23 Jun 2008 08:44:04 -0400
To:	<bug-Perl-Critic [...] rt.cpan.org>
From:	"Smith, Mark E CTR USAF AFMC AEDC/ATA" <Mark.E.Smith [...] arnold.af.mil>

The values I set in perlcriticrc are ignored when I run perlcritic. For example # Perl Best Practices theme = pbp If I use -theme pbp on the command line the results are as expected. I don't know if this is only a perlcritic issue or also a module issue. This may result from old installed perl modules. This is on a Red Hat EL 5 machine that does not get updated often. perlcritic version: 1.087 perl version: 5.8.8 I did some investigation and found that perlcritic is read and the value placed in $CRITIC->{_config}, but if I use -theme pbp on the command line there are many more policies included.

Mon Jun 23 10:47:30 2008 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #37021] perlcritcrc settings ignored
Date:	Mon, 23 Jun 2008 07:46:47 -0700
To:	bug-Perl-Critic [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

Smith, Mark E CTR USAF AFMC AEDC/ATA via RT wrote: Show quoted text

> The values I set in perlcriticrc are ignored when I run perlcritic. > For example > > # Perl Best Practices theme = pbp > > If I use -theme pbp on the command line the results are as expected. > I don't know if this is only a perlcritic issue or also a module > issue. > > This may result from old installed perl modules. This is on a Red Hat > EL 5 machine that does not get updated often. > > perlcritic version: 1.087 perl version: 5.8.8 > > I did some investigation and found that perlcritic is read and the > value placed in $CRITIC->{_config}, but if I use -theme pbp on the > command line there are many more policies included.

This is interesting because the tests depend upon the theme coming from the file working in environments with any non-core policies installed. I'm going to have to think on how to debug this.

Mon Jun 23 10:47:34 2008 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 09 15:50:56 2008 thaljef [...] cpan.org - Correspondence added

I'm stumped too. It might help if you sent over your .perlcriticrc file and the exact command lines you are using. Otherwise, it could be something as simple as a misplaced/misnamed .perlcriticrc file. But then you say it did pick up the values from your config file, so I'm not sure. -Jeff

Thu Jul 10 09:13:04 2008 Mark.E.Smith [...] arnold.af.mil - Correspondence added

Subject:	RE: [rt.cpan.org #37021] perlcritcrc settings ignored
Date:	Thu, 10 Jul 2008 09:12:33 -0400
To:	<bug-Perl-Critic [...] rt.cpan.org>
From:	"Smith, Mark E CTR USAF AFMC AEDC/ATA" <Mark.E.Smith [...] arnold.af.mil>

All that is in the .perlcriticrc is theme = pbp Perhaps I should capture a dump of the hash that contains the settings and send that. I could do it with and without -theme pbp as a command line argument. Just let me know where in the code to do it and what to dump. Mark Show quoted text

-----Original Message----- From: Jeffrey Ryan Thalhammer via RT [mailto:bug-Perl-Critic@rt.cpan.org] Sent: Wednesday, July 09, 2008 2:51 PM To: Smith, Mark E CTR USAF AFMC AEDC/ATA Subject: [rt.cpan.org #37021] perlcritcrc settings ignored <URL: http://rt.cpan.org/Ticket/Display.html?id=37021 > I'm stumped too. It might help if you sent over your .perlcriticrc file and the exact command lines you are using. Otherwise, it could be something as simple as a misplaced/misnamed .perlcriticrc file. But then you say it did pick up the values from your config file, so I'm not sure. -Jeff

Sun Jul 27 00:21:38 2008 thaljef [...] cpan.org - Correspondence added

On Thu Jul 10 09:13:04 2008, Mark.E.Smith@arnold.af.mil wrote: Show quoted text

> All that is in the .perlcriticrc is > > theme = pbp > > Perhaps I should capture a dump of the hash that contains the settings > and send that. I could do it with and without -theme pbp as a command > line argument. Just let me know where in the code to do it and what to > dump.

Maybe try setting a breakpoint in Perl::Critic::Config::_load_policies() and see what is going on there. Be sure to step into _policy_is_thematic() and check out what is happening in there too.

Mon Aug 11 12:33:29 2008 Mark.E.Smith [...] arnold.af.mil - Correspondence added

Subject:	RE: [rt.cpan.org #37021] perlcritcrc settings ignored
Date:	Mon, 11 Aug 2008 12:32:30 -0400
To:	<bug-Perl-Critic [...] rt.cpan.org>
From:	"Smith, Mark E CTR USAF AFMC AEDC/ATA" <Mark.E.Smith [...] arnold.af.mil>

I discovered that setting the theme to pbp in .perlcriticrc also requires that I set the severity level to 1. When I do this the behavior is as expected. Setting -theme pbp on the command line automatically sets the severity level to 1. Show quoted text

-----Original Message----- From: Jeffrey Ryan Thalhammer via RT [mailto:bug-Perl-Critic@rt.cpan.org] Sent: Saturday, July 26, 2008 11:22 PM To: Smith, Mark E CTR USAF AFMC AEDC/ATA Subject: [rt.cpan.org #37021] perlcritcrc settings ignored <URL: http://rt.cpan.org/Ticket/Display.html?id=37021 > On Thu Jul 10 09:13:04 2008, Mark.E.Smith@arnold.af.mil wrote:

> All that is in the .perlcriticrc is > > theme = pbp > > Perhaps I should capture a dump of the hash that contains the settings > and send that. I could do it with and without -theme pbp as a command > line argument. Just let me know where in the code to do it and what to > dump.

Maybe try setting a breakpoint in Perl::Critic::Config::_load_policies() and see what is going on there. Be sure to step into _policy_is_thematic() and check out what is happening in there too.

Sat Jan 17 18:57:11 2009 thaljef [...] cpan.org - Status changed from 'open' to 'stalled'

Bug #37021 for Perl-Critic: perlcritcrc settings ignored

Preferred bug tracker