Bug #36974 for Config-Tiny: read fail on /dev/null

"Adam Kennedy via RT" <bug-Config-Tiny@rt.cpan.org> writes: Show quoted text
I'd incline towards something like below. In the spirit of tiny-ness it leaves strerror() to provide the error messages. open() fails for no such file or permission denied, the read fails for a directory. But it's happy to read from a char special like /dev/null. (Unless one of the slurp modules does the same thing in one line.)

--- Tiny.pm.old 2008-10-01 09:10:58.000000000 +1000 +++ Tiny.pm 2008-10-01 09:20:08.000000000 +1000 @@ -17,17 +17,21 @@ my $class = ref $_[0] ? ref shift : shift; # Check the file - my $file = shift or return $class->_error( 'You did not specify a file name' ); - return $class->_error( "File '$file' does not exist" ) unless -e $file; - return $class->_error( "'$file' is a directory, not a file" ) unless -f _; - return $class->_error( "Insufficient permissions to read '$file'" ) unless -r _; + my $file = shift; + if (! defined $file) { + return $class->_error( 'You did not specify a file name' ); + } # Slurp in the file - local $/ = undef; open CFG, $file or return $class->_error( "Failed to open file '$file': $!" ); - my $contents = <CFG>; + my $contents = do { local $/ = undef; <CFG> }; close CFG; + if (! defined $contents) { + # EISDIR here if a directory, or EIO always possible + return $class->_error( "Cannot read file '$file': $!" ); + } + $class->read_string( $contents ); }