Bug #36815 for Regexp-Assemble: bleadperl@33874 breaks R:A

Tue Jun 17 00:23:13 2008 ANDK [...] cpan.org - Ticket created

Subject:

bleadperl@33874 breaks R:A

My smoker complained about: t/00_basic..........Bareword "_re_sort" not allowed while "strict subs" in use at /home/sand/.cpan/build/Regexp-Assemble-0.33-nLRWXw/blib/lib/Regexp/Assemble.pm line 2669. Bareword "_re_sort" not allowed while "strict subs" in use at /home/sand/.cpan/build/Regexp-Assemble-0.33-nLRWXw/blib/lib/Regexp/Assemble.pm line 2673. Compilation failed in require at t/00_basic.t line 20. BEGIN failed--compilation aborted at t/00_basic.t line 20. Dubious, test returned 9 (wstat 2304, 0x900) No subtests run Time to run a binary search and find it was patch 33874. Of course, Assemble.pm contains 'use strict' but then uses _re_sort long before defining it. Simply inserting a predeclare fixes this bug. Greets,

Tue Jun 17 16:54:39 2008 dland [...] cpan.org - Correspondence added

On Tue Jun 17 00:23:13 2008, ANDK wrote: Show quoted text

> My smoker complained about: > > t/00_basic..........Bareword "_re_sort" not allowed while "strict > subs" > in use at > /home/sand/.cpan/build/Regexp-Assemble-0.33- > nLRWXw/blib/lib/Regexp/Assemble.pm > line 2669. > Bareword "_re_sort" not allowed while "strict subs" in use at > /home/sand/.cpan/build/Regexp-Assemble-0.33- > nLRWXw/blib/lib/Regexp/Assemble.pm > line 2673. > Compilation failed in require at t/00_basic.t line 20. > BEGIN failed--compilation aborted at t/00_basic.t line 20. > Dubious, test returned 9 (wstat 2304, 0x900) > No subtests run > > > Time to run a binary search and find it was patch 33874. Of course, > Assemble.pm contains 'use strict' but then uses _re_sort long before > defining it. > > Simply inserting a predeclare fixes this bug.

Hi Andreas, thanks for the report. I was able to duplicate the problem with blead@34016. Unfortunately a forward declaration did not fix the problem. It seems like sort(foo @list) is no longer acceptable. I rewrote the code, since it was a little weird that way anyway. 0.34 is currently on ftp.funet.fi and will be propagating outwards over the next day or so. Thanks again for your smoking efforts, I don't know what we'd do without you! David

Tue Jun 17 16:54:41 2008 The RT System itself - Status changed from 'new' to 'open'

Tue Jun 17 16:54:43 2008 dland [...] cpan.org - Given to DLAND

Wed Jun 18 15:43:59 2008 dland [...] cpan.org - Fixed in 0.34 added

Wed Jun 18 15:43:59 2008 dland [...] cpan.org - Correspondence added

Fixed in 0.34 Thanks for the heads-up, David

Wed Jun 18 15:44:03 2008 dland [...] cpan.org - Status changed from 'open' to 'resolved'