* Jakob Hirsch via RT (bug-Mail-IMAPClient@rt.cpan.org) [080613 15:33]:
Show quoted text> Fri Jun 13 11:33:35 2008: Request 36726 was acted upon.
> Transaction: Ticket created by jh@plonk.de
> Queue: Mail-IMAPClient
> Subject: incorrect append_file() return code
> Broken in: (no value)
> Severity: (no value)
> Owner: Nobody
> Requestors: jh@plonk.de
> Status: new
> Ticket <URL:
http://rt.cpan.org/Ticket/Display.html?id=36726 >
>
>
> the man page says, append_file() will return true (or the uid, if
> supported) for successful appends, but at least versions 3.05 and 3.08
> return undef instead. The obvious fix for this is attached.
No, it doesn't.
If there is no 'OK', it will return undef.
If there is an 'OK', then the UID is returned (if supported), and otherwise
some other trueth value being $self.
So, I think you patch is not correct, and the existing code is correct.
But I may be wrong, convince me!
Show quoted text> --- IMAPClient.pm 2008-06-13 13:59:57.000000000 +0200
> +++ IMAPClient.pm 2008-05-26 13:25:39.000000000 +0200
> @@ -2474,7 +2478,7 @@
> }
> $fh->close;
>
> - $code ne 'OK' ? undef
> + $code eq 'OK' ? undef
> : defined $uid ? $uid
> : $self;
> }
--
Regards,
MarkOv
------------------------------------------------------------------------
Mark Overmeer MSc MARKOV Solutions
Mark@Overmeer.net solutions@overmeer.net
http://Mark.Overmeer.net http://solutions.overmeer.net
