| Subject: | use tabs-expanded column number for %c |
| Date: | Tue, 03 Jun 2008 09:48:05 +1000 |
| To: | bug-perl-critic [...] rt.cpan.org |
| From: | Kevin Ryde <user42 [...] zip.com.au> |
It'd be nice if the %c in the error output format spec used the
"tabs-expanded" column position that PPI provides in location->[2], as
opposed to the "row-char" of location->[1].
A position including tabs expanded is of course how the code appears on
the screen, and in particular emacs error positioning wants a
tabs-expanded position.
I guess there could be a place for a %C which was row-char, in case
someone needed it, though I'd be very inclined to make tabs-expanded the
default.
(Current PPI has some caveats in the docs about tab_width not being
ready yet, but it looks like the code is ahead of the docs. The default
though is tab_width 1, so row-char and tabs-expanded are the same, but
hopefully that can change quite soon :-)