Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 36385
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: user42 [...] zip.com.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jun 02 19:42:22 2008 user42 [...] zip.com.au - Ticket created
Subject: suggest perlcritic continue after parse error in one file
Date: Tue, 03 Jun 2008 09:41:55 +1000
To: bug-perl-critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
If PPI throws a parse error for a file, it seems the perlcritic front-end program stops at that point. It'd be good if it would continue on with further files given on the command line (or recursing through a tree). You can get a sample parse error from current ppi with a nul, ie. \0 byte in a file; so with such a file "perlcritic nul.pl foo.pl" shows the problem. Perhaps perlcritic should bail out on exceptions related to its own critiquing code, but an error, like a parse, related only to the one file needn't prevent others being checked.
  Tue Jun 03 02:25:28 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #36385] suggest perlcritic continue after parse error in one file
Date: Tue, 03 Jun 2008 01:25:11 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kevin Ryde via RT wrote: Show quoted text
> If PPI throws a parse error for a file, it seems the perlcritic > front-end program stops at that point. It'd be good if it would > continue on with further files given on the command line (or recursing > through a tree). > > You can get a sample parse error from current ppi with a nul, ie. \0 > byte in a file; so with such a file "perlcritic nul.pl foo.pl" shows the > problem. > > Perhaps perlcritic should bail out on exceptions related to its own > critiquing code, but an error, like a parse, related only to the one > file needn't prevent others being checked.
Which P::C version is this? This should be fixed in 1.084.
  Tue Jun 03 02:25:29 2008 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 03 20:31:14 2008 KRYDE [...] cpan.org - Correspondence added
Ah, I was on 1.082, debian hasn't yet got the latest and greatest.
  Fri Jun 20 14:04:14 2008 user42 [...] zip.com.au - Correspondence added
Subject: Re: [rt.cpan.org #36385] suggest perlcritic continue after parse error in one file
Date: Thu, 19 Jun 2008 10:02:29 +1000
To: bug-Perl-Critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
With perlcritic 1.086 and Regexp::Parser 0.20 perlcritic seems to die on a regexp parse error, eg. perlcritic -1 foo.pm bar.pm Fatal error while critiquing "foo.pm": Nested quantifiers; marked by <-- HERE in m/[x]++ <-- HERE / at /usr/share/perl5/Regexp/Parser/Objects.pm line 719 on the two files below. (In this case the "++" in foo.pm is meant to be a non-backtracking repeat, which I guess Regexp::Parser doesn't take yet.)

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

  Thu Jul 24 19:43:59 2008 user42 [...] zip.com.au - Correspondence added
Subject: Re: [rt.cpan.org #36385] suggest perlcritic continue after parse error in one file
Date: Fri, 25 Jul 2008 09:43:29 +1000
To: bug-Perl-Critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
"Elliot Shank via RT" <bug-Perl-Critic@rt.cpan.org> writes: Show quoted text
> > This should be fixed in 1.084.
I've lost track of whether 1.084 was ok, but it seems 1.090 is not. Per the first message perlcritic nul.pl foo.pl stops at the nul.pl with Fatal error while critiquing "nul.pl": PPI::Exception=HASH(0x96bcdd8) where I hoped it could continue with the rest of the files. (This is with PPI 1.204_01 which still has trouble with a \0 in a file.) I struck this running perlcritic on a whole /usr/share/perl5 tree where it stops at a File/._Temp.pm which is some stray macintosh thing, or on a /usr/share/perl/5.10.0 tree where CPAN.pm which has a stray \0.
  Thu Jul 24 20:06:40 2008 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #36385] suggest perlcritic continue after parse error in one file
Date: Thu, 24 Jul 2008 17:06:14 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kevin Ryde via RT wrote: Show quoted text
> I've lost track of whether 1.084 was ok, but it seems 1.090 is not. > Per the first message > > perlcritic nul.pl foo.pl > > stops at the nul.pl with > > Fatal error while critiquing "nul.pl": PPI::Exception=HASH(0x96bcdd8) > > where I hoped it could continue with the rest of the files.
I'll have a look.
  Mon Apr 13 13:43:22 2009 wyant [...] cpan.org - Correspondence added
On Thu Jul 24 20:06:40 2008, clonezone wrote: Show quoted text
> Kevin Ryde via RT wrote:
> > I've lost track of whether 1.084 was ok, but it seems 1.090 is not. > > Per the first message > > > > perlcritic nul.pl foo.pl > > > > stops at the nul.pl with > > > > Fatal error while critiquing "nul.pl":
PPI::Exception=HASH(0x96bcdd8) Show quoted text
> > > > where I hoped it could continue with the rest of the files.
> > I'll have a look.
This appears to me to be fixed in 1.098.
  Thu Sep 30 19:16:06 2010 thaljef [...] cpan.org - Correspondence added
RT-Send-CC: perl [...] galumph.com
This appears to be fixed in version 1.105 (or possibly earlier). So I'm going to mark this as resolved. Let me know if you find otherwise.
  Thu Sep 30 19:16:29 2010 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'