Skip Menu |

This queue is for tickets about the Apache-Test CPAN distribution.

Report information
The Basics
Id: 36305
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Apache-Test
People
Owner: Nobody in particular
Requestors: RFRANKEL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 1.29
  • 1.30
Fixed in: (no value)

History Show all quoted text
  Fri May 30 13:43:16 2008 RFRANKEL [...] cpan.org - Ticket created
Subject: Overridden get_basic_credentials broken w/ NTLM Authentication
Apache::TestRequest::get_basic_credentials dies when accessing a realm using mod_ntlm for authentication. The reason is that $realm is undefined. Patch to fix below: --- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500 +++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400 @@ -260,7 +260,7 @@ my($self, $realm, $uri, $proxy) = @_; for ($realm, '__ALL__') { - next unless $credentials{$_}; + next unless $_ && $credentials{$_}; return @{ $credentials{$_} }; }
  Fri May 30 18:30:14 2008 PHRED [...] cpan.org - Correspondence added
From: PHRED [...] cpan.org
Thanks for the spot, patch applied in revision 661903! On Fri May 30 13:43:16 2008, RFRANKEL wrote: Show quoted text
> Apache::TestRequest::get_basic_credentials dies when accessing a realm > using mod_ntlm for authentication. The reason is that $realm is undefined. > > Patch to fix below: > > --- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500 > +++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400 > @@ -260,7 +260,7 @@ > my($self, $realm, $uri, $proxy) = @_; > > for ($realm, '__ALL__') { > - next unless $credentials{$_}; > + next unless $_ && $credentials{$_}; > return @{ $credentials{$_} }; > }
  Fri May 30 18:31:32 2008 The RT System itself - Status changed from 'new' to 'open'
  Fri May 30 18:32:07 2008 PHRED [...] cpan.org - Correspondence added
From: PHRED [...] cpan.org
Thanks for the spot, patch applied! On Fri May 30 13:43:16 2008, RFRANKEL wrote: Show quoted text
> Apache::TestRequest::get_basic_credentials dies when accessing a realm > using mod_ntlm for authentication. The reason is that $realm is undefined. > > Patch to fix below: > > --- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500 > +++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400 > @@ -260,7 +260,7 @@ > my($self, $realm, $uri, $proxy) = @_; > > for ($realm, '__ALL__') { > - next unless $credentials{$_}; > + next unless $_ && $credentials{$_}; > return @{ $credentials{$_} }; > }
  Fri May 30 18:33:00 2008 PHRED [...] cpan.org - Correspondence added 5 min
Patch applied, fix will be released in Apache::Test 1.31.
  Fri May 30 18:33:02 2008 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'