Skip Menu |

This queue is for tickets about the Data-FormValidator CPAN distribution.

Maintainer(s)' notes

This is the bug queue for Data::FormValidator.

Report information
The Basics
Id: 36284
Status: rejected
Priority: 0/
Queue: Data-FormValidator

People
Owner: MARKSTOS [...] cpan.org
Requestors: robert.stockdale [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.50
Fixed in: (no value)



Subject: FV_eq_with return value bug
The coderef returned by FV_eq_with returns true or false instead of the untainted param value.
Subject: Re: [rt.cpan.org #36284] FV_eq_with return value bug
Date: Thu, 29 May 2008 15:03:08 -0400
To: bug-Data-FormValidator [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Show quoted text
> The coderef returned by FV_eq_with returns true or false instead of the > untainted param value.
And perhaps it shouldn't. Comparing that values are equal doesn't provide any assurance that either one is safe. The underlying tainting system is based on checking that values match safe patterns, which this constraint doesn't do. Therefore, it doesn't strike me as wise to fake untainting of the values here. The constraint also can't know which of the two inputs might be "safe", to pre-empt the suggestion that if one of the inputs is safe and they are equal, then the other input should be safe, too. If you'd like to discuss it further, I suggest doing so on the users mailing list, so you could get more perspectives besides my own. Mark
Since there has been no further discussion, I'm taking my last comment as the final response, so am considering this bug rejected. Mark