| Subject: | Test::Pod::Coverage Not Needed by Crypt::Cracklib |
Dear Dan Sully,
Hi. This is imacat from Taiwan. I was installing your
newly-released Crypt-Cracklib-1.4, and found that Test::Pod::Coverage
was listed as a prerequisite. But I believe that Crypt-Cracklib-1.4
does not need Test::Pod::Coverage at all. Only the test suite in
t/pod-coverage.t needs Test::Pod::Coverage. This creates unnecessary
module dependency. I would suggest you use an eval() in
t/pod-coverage.t, and skip tests if Test::Pod::Coverage is not
available, as suggested in the Test::Pod::Coverage documentation:
<<Test::Pod::Coverage>>
http://search.cpan.org/perldoc?Test::Pod::Coverage
If you are using Module::Build you can use "build_requires" to list
the prerequisites only for the build process.
I made a simple patch against Crypt-Cracklib-1.4 for this, in the
hope that it helps. Please tell me if you need any more information, or
if I could be of any help. Thank you.
| Subject: | Crypt-Cracklib-1.4-podcov.diff |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
diff -u -r Crypt-Cracklib-1.4.orig/Makefile.PL Crypt-Cracklib-1.4/Makefile.PL
- --- Crypt-Cracklib-1.4.orig/Makefile.PL 2008-05-18 23:22:45.000000000 +0800
+++ Crypt-Cracklib-1.4/Makefile.PL 2008-05-25 13:55:17.000000000 +0800
@@ -36,8 +36,6 @@
perl_version('5.004');
all_from('Cracklib.pm');
- -test_requires 'Test::Pod::Coverage' => '1.08';
- -test_requires 'Pod::Coverage' => '0.19';
test_requires 'Test::More' => '0.47';
cc_lib_links('crack');
diff -u -r Crypt-Cracklib-1.4.orig/t/pod-coverage.t Crypt-Cracklib-1.4/t/pod-coverage.t
- --- Crypt-Cracklib-1.4.orig/t/pod-coverage.t 2007-01-06 05:27:16.000000000 +0800
+++ Crypt-Cracklib-1.4/t/pod-coverage.t 2008-05-25 13:47:15.000000000 +0800
@@ -1,2 +1,6 @@
- -use Test::Pod::Coverage tests => 1;
+use Test::More;
+eval "use Test::Pod::Coverage";
+plan skip_all => "Test::Pod::Coverage required for testing pod coverage" if $@;
+
+plan tests => 1;
pod_coverage_ok("Crypt::Cracklib", "Crypt::Cracklib is covered" );
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkg4/2IACgkQi9gubzC5S1xrwQCeLX9AwziylUQ71dJ/oVMCnFnt
eo0An1qExd2yrtH1GFXRsDl76IW86Hvc
=bdT+
-----END PGP SIGNATURE-----