Skip Menu |

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 35925
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: dave.s.doyle [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.30
Fixed in: (no value)

Attachments


Subject: CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
I noticed this in my error logs when using CGI::Session in CGI::Application. When I've passed a DBI object to CGI::Session via CGI::Application::Plugin::Session and the request is ending, the DBI object is being destroyed before the Session. CGI::Session::Driver::DBI::DESTROY does a "ping" on the DBH so it can do a $self->set_error() stating that the handle was destroyed. However, because the handle is already gone the ->ping produces a "Can't call method ping on undefined value". If you change the if statement to include a check if $self->{Handle} is defined as well as if ->ping works, no more warning. Not a big deal, but it's cluttering my logs. :) Patch enclosed. Thanks for your time and a great module.
Subject: CGI-Session-Driver-DBI_DESTROY-patch
Download CGI-Session-Driver-DBI_DESTROY-patch
application/octet-stream 479b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
Date: Fri, 16 May 2008 16:07:22 +1000
To: bug-CGI-Session [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Show quoted text
> Not a big deal, but it's cluttering my logs. :)
Reason enough to shake our tree. Show quoted text
> Patch enclosed.
Thanx for the patch. I'll apply it to SVN tonight, but I can't say how long before another version of CGI::Session is released. Show quoted text
> Thanks for your time and a great module.
$many x $thanx; -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
Date: Fri, 16 May 2008 16:38:20 +1000
To: bug-CGI-Session [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Folks Updated in svn. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
Date: Tue, 27 May 2008 13:10:47 -0400
To: bug-CGI-Session [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Show quoted text
> Hi Folks > > Updated in svn.
Thanks, Ron. Shall I go ahead with another release then? Mark
Subject: Re: [rt.cpan.org #35925] CGI::Session::Driver::DBI::DESTROY throws a warning when DBI is destroyed before session object
Date: Wed, 28 May 2008 10:37:05 +1000
To: bug-CGI-Session [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Mark On Tue, 2008-05-27 at 13:11 -0400, mark@summersault.com via RT wrote: Show quoted text
> Queue: CGI-Session > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=35925 > >
> > Hi Folks > > > > Updated in svn.
> > Thanks, Ron. Shall I go ahead with another release then?
Please wait a day or so. I'll have a look at the other email and doc implications, and let you know. -- Ron Savage ron@savage.net.au http://savage.net.au/index.html
From: dave.s.doyle [...] gmail.com
Thanks again for the change. This is fixed in 4.31/4.32 so you you can probably mark this as resolved. ;) Thanks for my first ever patch (small though it may be) to a CPAN module and both of you responding so quick! D
The reporter said this was fixed in 4.32.